fix: use timezone-aware UTC webhook timestamps - #344
Merged
eshulman2 merged 2 commits intoSep 27, 2026
Merged
Conversation
Replace deprecated utcnow calls for webhook creation and terminal status updates. Add warning-as-error regression tests for all four paths and document strict timestamp verification.
JoshSalomon
force-pushed
the
codex/fix-webhook-utc-timestamps
branch
from
September 23, 2026 17:18
e46b4a4 to
430558a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime.utcnow()calls inWebhookEventwith timezone-awaredatetime.now(UTC)timestamps, including a per-instance creation-time factory.received_atthroughpublish_onceinto the Redis queue message, so the timestamp consumed by the Jira event adapter is UTC-aware. Calls without an explicit timestamp now receive an aware UTC timestamp frompublish_once.This PR is limited to Forge's webhook-event timestamps. It does not include the separate forge-poller acknowledgment fix, change live workflow state, or migrate stored data. Caller-supplied timestamps are preserved as before.
Rebase
Rebased onto
mainat08f98d3, which includes the maintainer's CI fixes in #345.Verification
pytest tests/unit/models/test_events.py tests/unit/queue tests/unit/api/routes/test_jira_webhook.py tests/unit/orchestrator/event_adapters/test_registry.py -q -W error::DeprecationWarning.git diff --checkpasses.