Repository navigation
fix(menubar): read the download whole so Electron's Node cannot crash mid-update - #1745
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop app runs codeburn update under Electron's Node 24, whose bundled undici hits assert(!this.paused) and kills the process when a server closes the socket while a piped download is paused on the file write. In the end-to-end update test this left the menu bar on the old version in 2 of 5 desktop-driven runs.
The menu bar zip (about 8 MB) is now read whole and written once. 12 of 12 runs passed under Electron's Node against a server that closes every connection; menubar installer tests (175) and tsc pass.