Skip to content

fix(menubar): read the download whole so Electron's Node cannot crash mid-update #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamtoruk merged 1 commit into from
Oct 11, 2026
Merged

fix(menubar): read the download whole so Electron's Node cannot crash mid-update #1745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/menubar-installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { spawn } from 'node:child_process'
import { createHash } from 'node:crypto'
import { once } from 'node:events'
import { createWriteStream, constants as fsConstants } from 'node:fs'
import { constants as fsConstants } from 'node:fs'
import { access, chmod, cp, lstat, mkdir, mkdtemp, readFile, readdir, rename, rm, stat, writeFile } from 'node:fs/promises'
import { homedir, platform, tmpdir } from 'node:os'
import { basename, dirname, isAbsolute, join, resolve } from 'node:path'
import { pipeline } from 'node:stream/promises'
import { Readable } from 'node:stream'
import { ProxyAgent, fetch as undiciFetch } from 'undici'

import { getCodeburnCacheDir } from './cache-dir.js'
Expand Down Expand Up @@ -663,10 +661,10 @@ export async function downloadToFile(
// A 2xx with no body is the most retryable response there is; throw so the retry picks it up
// rather than writing a zero-byte file that verifyChecksum would later reject as a mismatch.
if (response.body === null) throw new Error('response had no body')
// fetch's ReadableStream needs to be wrapped for Node streams.
const nodeStream = Readable.fromWeb(response.body as never)
// Read whole, not piped: Electron's Node 24 undici asserts and kills the process when a
// server closes the socket while a paused body waits on the file write.
try {
await pipeline(nodeStream, createWriteStream(destPath))
await writeFile(destPath, Buffer.from(await new Response(response.body as BodyInit).arrayBuffer()))
} catch (err) {
// A mid-stream drop leaves a truncated file. Remove it before re-throwing so the retry
// starts clean and a genuine failure never leaves a partial artifact behind.
Expand Down
Loading