Skip to content

optimize: stop counting new-file writes in the read/edit ratio #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamtoruk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimize: stop counting new-file writes in the read/edit ratio #1761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/optimize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3084,6 +3084,9 @@ export function detectBloatedClaudeMd(projectCwds: Set<string>): WasteFinding |
export const READ_TOOL_NAMES = new Set(['Read', 'Grep', 'Glob', 'FileReadTool', 'GrepTool', 'GlobTool'])
export const EDIT_TOOL_NAMES = new Set(['Edit', 'Write', 'FileEditTool', 'FileWriteTool', 'NotebookEdit'])
export const BASH_TOOL_NAMES = new Set(['Bash', 'BashTool', 'PowerShellTool'])
// Writing a new file has nothing to read first; counting Write flagged subagents
// that produce reports as editing blind. Not EDIT_TOOL_NAMES: act report baselines use that.
const RATIO_EDIT_TOOL_NAMES = new Set(['Edit', 'FileEditTool', 'NotebookEdit'])

export function detectLowReadEditRatio(calls: ToolCall[]): WasteFinding | null {
let reads = 0
Expand All @@ -3100,7 +3103,7 @@ export function detectLowReadEditRatio(calls: ToolCall[]): WasteFinding | null {
// reckless editors (90%+ of real reads were invisible to this ratio).
reads++
if (call.recent) recentReads++
} else if (EDIT_TOOL_NAMES.has(call.name)) {
} else if (RATIO_EDIT_TOOL_NAMES.has(call.name)) {
edits++
if (call.recent) recentEdits++
}
Expand Down
7 changes: 5 additions & 2 deletions tests/optimize.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,16 @@ describe('detectLowReadEditRatio', () => {
expect(detectLowReadEditRatio(calls)).toBeNull()
})

it('counts Write as edit', () => {
it('does not count Write as edit', () => {
// Subagents writing new report files have nothing to read first.
const calls = [
...Array.from({ length: 15 }, () => call('Read', {})),
...Array.from({ length: 10 }, () => call('Write', {})),
...Array.from({ length: 10 }, () => call('Edit', {})),
...Array.from({ length: 30 }, () => call('Write', {})),
]
const finding = detectLowReadEditRatio(calls)
expect(finding).not.toBeNull()
expect(finding!.explanation).toContain('15 reads and 10 edits')
})
})

Expand Down
Loading