Skip to content

fix(updater): bring the app back when a silent Windows update's UAC is declined #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EtienneLescot wants to merge 1 commit into from
Closed

fix(updater): bring the app back when a silent Windows update's UAC is declined #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions build/installer.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
; Picked up by electron-builder as `<buildResources>/installer.nsh` (the NSIS `include` option).

; A silent update of a per-machine install (`/S`, see installsSilently in electron/auto-updater.ts)
; asks for UAC in the install section, by which time the app has already quit. Declining it
; (error 1223) makes electron-builder's installer.nsi just Quit, so OpenScreen stays closed (#1461).
; Elevate here instead, as the stock section would, and bring the app back if that fails. The
; downloaded update stays cached, so the user can retry it.
!macro customInit
${if} ${Silent}
${andIf} $hasPerMachineInstallation == "1"
${andIfNot} ${UAC_IsAdmin}
!insertmacro UAC_RunElevated
${if} $0 != 0
${andIf} ${isForceRun}
ExecShell "open" "$perMachineInstallationFolder\${APP_EXECUTABLE_FILENAME}"
${endIf}
Quit
${endIf}
!macroend
Loading