Repository navigation
Key rotation - #323
Merged
Merged
Key rotation#323
Conversation
mfield4
force-pushed
the
key-rotation
branch
2 times, most recently
from
October 30, 2026 00:30
4ca0e9a to
8acea00
Compare
mfield4
marked this pull request as ready for review
November 4, 2026 21:29
Define `LIBHOTH_MAX_MAILBOX_SIZE` (6,144 bytes) for targets with larger mailboxes such as OpenTitan Earlgrey while preserving `LIBHOTH_MAILBOX_SIZE` (1,024 bytes) for legacy chunked protocols. Widen `libhoth_hostcmd_exec` request and response buffers to `LIBHOTH_MAX_MAILBOX_SIZE` using a shared `union` so the stack footprint stays at 6 KiB, and update `command_raw_host_command` and test mock `CopyResp` to match.
Widen `LIBHOTH_USB_FIFO_MAX_REQUEST_SIZE` to `LIBHOTH_MAX_MAILBOX_SIZE` so USB FIFO transfers accept up to 6 KiB payloads. On spidev, enforce `LIBHOTH_MAX_MAILBOX_SIZE` on non-atomic multi-page writes, bound atomic `SPI_IOC_MESSAGE(5)` writes to a single 256-byte flash page, clamp SPI mailbox response reads to the 1 KiB hardware egress mailbox window, and ensure `buffered_request` is freed on error and device close.
Add `KEY_ROTATION_RECORD_WRITE_COMMIT` (op 12) and dispatch `libhoth_key_rotation_update` to single-command write-commit when the input record begins with the OpenTitan signed descriptor magic (`"KRSD"`), while preserving the legacy initiate/write/commit flow for Haven records.
ckungler
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for larger key rotation records