Repository navigation
fix: preserve failed pack health on readiness retry - #2661
Draft
groupthinking wants to merge 2 commits into
Draft
groupthinking wants to merge 2 commits into
groupthinking wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2659
Outcome
Build live now keeps failed or missing hosted health as failure after a stored-pack lookup. A stored pack no longer produces a live-ready receipt when its hosted output remains unhealthy. Healthy first probes and healthy retries remain supported.
Scope
verifyPackBuildLive.codex/fix-pack-readiness-20261112andcodex/fix-studio-cancellation-20261112from automatic Vercel deployments in both repository-root and app-root configurations, honoring the user's no-deployment scope.Risk and rollback
Risk: low. A stored pack whose hosted output fails health now shows failure instead of a false success. Rollback is a reviewed revert; it would restore the incorrect readiness behavior. No merge or deployment is authorized by this draft.
Verification
Final head:
d9b3393e437a84752b3bd84b775015548bc9a5cf. Final tree:6e49d311f8e90480be276f3681d9d50e4b0e36ff, verified identical between the local review tree and GitHub's created tree.Environment: Node 24.22.1, npm 11.9.0, installed app Vitest 5.1.0. Frozen
npm ci --ignore-scripts --legacy-peer-deps --no-audit --no-fund; lockfile unchanged; inspected existing Workflow postinstall patch run explicitly.npm --workspace=apps/web test -- src/lib/__tests__/pack-build-live.test.ts src/lib/__tests__/compiled-spec-host.test.ts src/components/__tests__/OneLoopStudio.build-live.test.tsx --maxWorkers=2: 29 passed, exit 0.npm --workspace=apps/web test -- --maxWorkers=2: 1,568 passed / 28 skipped across 171 files, exit 0.git diff --check: exit 0.Production evidence
No live extraction, hosted build, checkout, deployment or production probe was performed. Vercel project lookup through the current connection returned 404, so provider-side deployment absence is not independently certified. The first published branch commit already contains the exact-branch deployment exclusions.
Combined verification with the cancellation fix also passed: 1,581 tests / 28 skipped across 172 files; full web type-check and lint passed, all exit 0. Combined tree e3eada50efabfbdd0895cb589a0f930c89e72978 matches a clean three-way calculation. No merge was performed.
Current-head follow-through (2026-11-12)
d9b3393e437a84752b3bd84b775015548bc9a5cf; fetched Git commit tree6e49d311f8e90480be276f3681d9d50e4b0e36ffmatches the isolated local test tree.No Vercel preview deployment became available for PR SHA d9b3393e437a84752b3bd84b775015548bc9a5cf.Exit 1; E2E tests were skipped.The required preview E2E gate is preserved. Both exact branch names remain disabled in
vercel.jsonandapps/web/vercel.json; no deployment, paid extraction, merge, check bypass, or CI weakening was performed. A hosted preview requires separate deployment authorization.Agent handoff
Codex owns current-head CI/review follow-through and concrete repairs. This is a draft for review only. Keep it unmerged and do not deploy. Cancellation is tracked separately in #2660.