Skip to content

fix: preserve failed pack health on readiness retry - #2661

Draft
groupthinking wants to merge 2 commits into
mainfrom
codex/fix-pack-readiness-20261112
Draft

groupthinking wants to merge 2 commits into
mainfrom
codex/fix-pack-readiness-20261112

Conversation

@groupthinking

@groupthinking groupthinking commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Closes #2659

Outcome

Build live now keeps failed or missing hosted health as failure after a stored-pack lookup. A stored pack no longer produces a live-ready receipt when its hosted output remains unhealthy. Healthy first probes and healthy retries remain supported.

Scope

  • Remove the ten-line success bypass in verifyPackBuildLive.
  • Replace the permissive degraded-health expectation and cover missing health and HTTP 503 with a nominally healthy payload.
  • Exclude only codex/fix-pack-readiness-20261112 and codex/fix-studio-cancellation-20261112 from automatic Vercel deployments in both repository-root and app-root configurations, honoring the user's no-deployment scope.
  • No provider calls, external tool execution, gate changes, dependencies or production changes.

Risk and rollback

Risk: low. A stored pack whose hosted output fails health now shows failure instead of a false success. Rollback is a reviewed revert; it would restore the incorrect readiness behavior. No merge or deployment is authorized by this draft.

Verification

Final head: d9b3393e437a84752b3bd84b775015548bc9a5cf. Final tree: 6e49d311f8e90480be276f3681d9d50e4b0e36ff, verified identical between the local review tree and GitHub's created tree.

Environment: Node 24.22.1, npm 11.9.0, installed app Vitest 5.1.0. Frozen npm ci --ignore-scripts --legacy-peer-deps --no-audit --no-fund; lockfile unchanged; inspected existing Workflow postinstall patch run explicitly.

  • Negative control, updated tests against original production source: 2 failed / 13 passed, exit 1.
  • npm --workspace=apps/web test -- src/lib/__tests__/pack-build-live.test.ts src/lib/__tests__/compiled-spec-host.test.ts src/components/__tests__/OneLoopStudio.build-live.test.tsx --maxWorkers=2: 29 passed, exit 0.
  • npm --workspace=apps/web test -- --maxWorkers=2: 1,568 passed / 28 skipped across 171 files, exit 0.
  • Web type-check, changed-file ESLint and git diff --check: exit 0.
  • Independent runner reviewed client, server contract, regression coverage and final branch exclusions: no blocking finding.
  • Both JSON configurations were parsed and their exact-branch false value checked. The deployment exclusion commits change configuration only; application source and tests are unchanged from the passing full suite. Both drafts use identical exclusion files.

Production evidence

No live extraction, hosted build, checkout, deployment or production probe was performed. Vercel project lookup through the current connection returned 404, so provider-side deployment absence is not independently certified. The first published branch commit already contains the exact-branch deployment exclusions.

Combined verification with the cancellation fix also passed: 1,581 tests / 28 skipped across 172 files; full web type-check and lint passed, all exit 0. Combined tree e3eada50efabfbdd0895cb589a0f930c89e72978 matches a clean three-way calculation. No merge was performed.

Current-head follow-through (2026-11-12)

  • Head remains d9b3393e437a84752b3bd84b775015548bc9a5cf; fetched Git commit tree 6e49d311f8e90480be276f3681d9d50e4b0e36ff matches the isolated local test tree.
  • CI run 43332012523, security scan, secret scan, dependency review, CodeQL, coverage and PR checks completed successfully. Inline review threads: 0.
  • E2E job 131578876857 failed before test execution with: No Vercel preview deployment became available for PR SHA d9b3393e437a84752b3bd84b775015548bc9a5cf. Exit 1; E2E tests were skipped.
  • Fresh isolated local rerun of the three-file focused command above: 29 passed / 3 files, exit 0 (Node 24.22.1, npm 11.9.0, Vitest 5.1.0; reused the existing locked dependency installation).
  • Source review found no additional blocking correction. No source commit was added during this follow-through.

The required preview E2E gate is preserved. Both exact branch names remain disabled in vercel.json and apps/web/vercel.json; no deployment, paid extraction, merge, check bypass, or CI weakening was performed. A hosted preview requires separate deployment authorization.

Agent handoff

Codex owns current-head CI/review follow-through and concrete repairs. This is a draft for review only. Keep it unmerged and do not deploy. Cancellation is tracked separately in #2660.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added javascript Pull requests that update javascript code tests labels Nov 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve failed health in Build live readiness

1 participant