Skip to content

ci: skip scenario-parity on dependabot PRs - #183

Merged
eddietejeda merged 1 commit into
mainfrom
ci/skip-scenario-parity-for-dependabot
Sep 3, 2026
Merged

ci: skip scenario-parity on dependabot PRs#183
eddietejeda merged 1 commit into
mainfrom
ci/skip-scenario-parity-for-dependabot

Conversation

@eddietejeda

Copy link
Copy Markdown
Contributor

Dependabot-triggered runs don't get repository secrets, so the create-github-app-token step in scenario-parity fails ("The 'private-key' input must be set") on every dependabot PR — this is why #163, #164, #165, and #182 are stuck. Dependency bumps can't affect scenario parity, so skip the job for the dependabot actor.

Note: sdk-rust has the same pattern in its workflow and will hit the same issue on its next dependabot PR.

@eddietejeda
eddietejeda requested a review from a team as a code owner September 3, 2026 00:06
@eddietejeda
eddietejeda requested review from zfarrell and removed request for a team September 3, 2026 00:06
Dependabot-triggered workflow runs don't receive repository secrets, so
the create-github-app-token step fails with an empty private-key before
the parity check can run — every dependabot PR fails this required-looking
check. Dependency bumps can't change scenario parity, so skip the job.
@eddietejeda
eddietejeda force-pushed the ci/skip-scenario-parity-for-dependabot branch from 984a865 to df04c91 Compare September 3, 2026 00:09
# Dependabot-triggered runs don't receive repository secrets, so the App
# token mint below fails before the check can run. Dependency bumps can't
# change scenario parity, so skip instead.
if: github.actor != 'dependabot[bot]'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Fork PRs also run without repository secrets, so scenario-parity still fails on them. (not blocking)

Widen the condition to cover forks:

Suggested change
if: github.actor != 'dependabot[bot]'
if: github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.fork != true

On push events github.event.pull_request is null, so the added clause stays true there. The integration job comment at line 85 already records that fork PRs get no secrets.

@eddietejeda
eddietejeda merged commit 00435bd into main Sep 3, 2026
4 checks passed
@eddietejeda
eddietejeda deleted the ci/skip-scenario-parity-for-dependabot branch September 3, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant