Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ jobs:
# same pattern as regenerate.yml.
scenario-parity:
runs-on: ubuntu-latest
# Dependabot-triggered runs don't receive repository secrets, so the App
# token mint below fails before the check can run. Dependency bumps can't
# change scenario parity, so skip instead.
if: github.actor != 'dependabot[bot]'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Fork PRs also run without repository secrets, so scenario-parity still fails on them. (not blocking)

Widen the condition to cover forks:

Suggested change
if: github.actor != 'dependabot[bot]'
if: github.actor != 'dependabot[bot]' && github.event.pull_request.head.repo.fork != true

On push events github.event.pull_request is null, so the added clause stays true there. The integration job comment at line 85 already records that fork PRs get no secrets.

steps:
- name: Generate GitHub App token
id: app-token
Expand Down