Repository navigation
test: log the error when a Kafka test loader exits - #253
Merged
Merged
Conversation
kafka_offset_floor and kafka_rebalance spawn the orchestrator and threw away what run() returned, so a loader that failed to start left a test waiting on a timeout with nothing in its output. They now log the error the way grpc_outage does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kafka_offset_floor and kafka_rebalance spawned the orchestrator and discarded the Result from run(). A loader that failed to start left the test waiting on a timeout with nothing in its output.
The "config cascade not initialised" warning in in-process loader logs is left alone. config::setup() in the test harness would make every from_cascade() reader pick up ./settings.yaml, ./config/ and /config/ from whatever machine runs the tests, and the tests are written against the readers' defaults.
Done when a Kafka test loader that exits with an error says so in the failing test's output.