Skip to content

test: log the error when a Kafka test loader exits #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catinspace-au merged 1 commit into from
Oct 12, 2026
Merged

test: log the error when a Kafka test loader exits #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/integration/kafka_offset_floor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,9 @@ fn start_loader(config: Config) -> (CancellationToken, JoinHandle<()>) {
let mut orchestrator = Orchestrator::new(config);
let shutdown = orchestrator.shutdown_token();
let loader = tokio::spawn(async move {
let _ = orchestrator.run().await;
if let Err(error) = orchestrator.run().await {
tracing::error!(%error, "the loader stopped with an error");
}
});
(shutdown, loader)
}
Expand Down
8 changes: 6 additions & 2 deletions tests/integration/kafka_rebalance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ async fn a_partition_moved_mid_buffer_lands_each_row_once() {
let first_guard = Arc::clone(first.memory_guard());
let stop_first = first.shutdown_token();
let first = tokio::spawn(async move {
let _ = first.run().await;
if let Err(error) = first.run().await {
tracing::error!(%error, "the first loader stopped with an error");
}
});
let deadline = tokio::time::Instant::now() + BUDGET;
let mut buffered = 0.0;
Expand All @@ -183,7 +185,9 @@ async fn a_partition_moved_mid_buffer_lands_each_row_once() {
let second_guard = Arc::clone(second.memory_guard());
let stop_second = second.shutdown_token();
let second = tokio::spawn(async move {
let _ = second.run().await;
if let Err(error) = second.run().await {
tracing::error!(%error, "the second loader stopped with an error");
}
});
let taken_over = settled_rows(&clickhouse, &table).await;

Expand Down
Loading