Skip to content

ci: use the shared CI workflow #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaysuk merged 1 commit into from
Oct 14, 2026
Merged

ci: use the shared CI workflow #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ on:

jobs:
test:
uses: jaysuk/dwc-plugin-test-kit/.github/workflows/dwc-plugin-ci.yml@v0.2.9
uses: jaysuk/dwc-plugin-workflows/.github/workflows/ci.yml@v1
with:
dwc-ref: v3.7-dev
kit-ref: v0.2.9
15 changes: 7 additions & 8 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ internals that aren't in that list.
6. `src/components/*.vue` — actual UI.
7. `src/i18n/en.json` — strings, registered via `registerPluginMessages`.
8. `src/__tests__/*.test.ts` — pure-logic unit tests. `test/component.test.ts` — mount smoke test.
9. `.github/workflows/ci.yml` — one line, reuses `dwc-plugin-test-kit`'s shared workflow.
9. `.github/workflows/ci.yml` — a few lines, calls the shared CI workflow in `jaysuk/dwc-plugin-workflows` (`ci.yml@v1`).

## `plugin.json` manifest

Expand Down Expand Up @@ -454,16 +454,15 @@ on:
pull_request:
jobs:
test:
uses: jaysuk/dwc-plugin-test-kit/.github/workflows/dwc-plugin-ci.yml@v0.2.6
uses: jaysuk/dwc-plugin-workflows/.github/workflows/ci.yml@v1
with:
dwc-ref: v3.7-dev
kit-ref: v0.2.6
```
Pin both `@v0.2.6` (the workflow ref) and `kit-ref: v0.2.6` (what it installs) to a real tag, matching
the `dwc-plugin-test-kit` version in `package.json` — every plugin in this family does this, not
`@main`, so a test-kit change can't silently break CI on an unrelated plugin the day it merges. Bump
both together when you deliberately upgrade the kit. Runs unit + mount tests, then in a second job
checks out DWC and runs `verify-build` + `typecheck`.
`@v1` is a floating major tag in `jaysuk/dwc-plugin-workflows` (the shared CI and release workflows for every
plugin in this family): a CI change there reaches all plugins without editing each repo, and a breaking one
becomes `@v2`. There is nothing else to pin: the `dwc-plugin-test-kit` version is just the one in
`package.json`. Runs unit + mount tests, then in a second job checks out DWC and runs `verify-build` +
`typecheck`, on Node 26.

## Known gotchas

Expand Down
Loading