Repository navigation
Move source files and header files under namespace directories - #469
Merged
Merged
Conversation
jbcoe
marked this pull request as draft
October 10, 2026 20:49
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 93.54% 94.95% +1.41%
==========================================
Files 11 9 -2
Lines 836 793 -43
Branches 41 25 -16
==========================================
- Hits 782 753 -29
Misses 26 26
+ Partials 28 14 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jbcoe
force-pushed
the
push-qymuqvmnmpnv
branch
2 times, most recently
from
October 10, 2026 21:29
985d5d8 to
ef43fca
Compare
jbcoe
changed the title
jbcoe
changed the title
jbcoe
force-pushed
the
push-qymuqvmnmpnv
branch
from
October 10, 2026 21:42
ef43fca to
04fe8af
Compare
jbcoe
force-pushed
the
push-qymuqvmnmpnv
branch
from
October 10, 2026 21:44
04fe8af to
72bea8e
Compare
jbcoe
marked this pull request as ready for review
October 10, 2026 22:01
Owner
Author
|
This just re-org and cleanup. Adding you both (@philipcraig , @RyanJK5 ) as reviewers to catch any work in flight. |
This was referenced Oct 11, 2026
philipcraig
approved these changes
Oct 11, 2026
- Put the detail headers in a :detail Bazel target that the tests depend on directly, rather than private headers of :protocol. - Find the coverage script's headers with one recursive glob under xyz/ and create each destination directory as files are copied, so any translation unit can be probed. - Move consteval_check.h, shared by tests and tutorials, to xyz/testing.
The tutorials include only consteval_check.h; .bazelrc already enables -freflection for every target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Headers, tests and tutorials move under
xyz/, and each directory's contentslive in the matching namespace, with
xyz/detailinxyz::detailandxyz/testsinxyz::tests. Includes are written from the repository root, soconsumers of the installed package include
xyz/protocol.hh.The
xyz::reflectionnamespace is removed andprotocol,protocol_viewandthe rest of the public API are now in
xyz. The name-mangling helpers, theinterface concepts and the
is_protocol/is_protocol_viewtraits move intoxyz::detailand are no longer public.Closes #470.
Closes #471.
Closes #472.
Closes #473.