Repository navigation
Restrict expression references to function arguments - #396
Closed
Narek-Khachikyan wants to merge 1 commit into
Closed
Narek-Khachikyan wants to merge 1 commit into
Narek-Khachikyan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search("[&foo]", {}) returns a list containing an internal _Expression object, and length([&foo]) silently returns 1.
_token_nud_expref registers & as a generic expression prefix even though expression-type is only an alternative of function-arg. Moving its parsing to the argument parser enforces the correct grammar context.
Expected: Compilation raises ParseError for & outside a direct function-argument position; map(&foo, items) and nested map calls remain valid.
Evidence
JMESPATH_TEST=tests/compliance/expref_context.json .tox/campaign/bin/python -m pytest tests/test_compliance.py -q --tb=shortdetects the baseline error and passes with the fix; the full pytest suite with branch coverage passes.Merge Danger
Door: two-way. Focused correction with regression tests; no new API.
Blast Radius: parsing.