Skip to content

Restrict expression references to function arguments #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Narek-Khachikyan wants to merge 1 commit into from
Closed

Restrict expression references to function arguments #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions jmespath/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,6 @@ def _parse_slice_expression(self):
def _token_nud_current(self, token):
return ast.current_node()

def _token_nud_expref(self, token):
expression = self._expression(self.BINDING_POWER['expref'])
return ast.expref(expression)

def _token_led_dot(self, left):
if not self._current_token() == 'star':
right = self._parse_dot_rhs(self.BINDING_POWER['dot'])
Expand Down Expand Up @@ -293,7 +289,11 @@ def _token_led_lparen(self, left):
name = left['value']
args = []
while not self._current_token() == 'rparen':
expression = self._expression()
if self._current_token() == 'expref':
self._advance()
expression = ast.expref(self._expression())
else:
expression = self._expression()
if self._current_token() == 'comma':
self._match('comma')
args.append(expression)
Expand Down
78 changes: 78 additions & 0 deletions tests/compliance/expref_context.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
[
{
"given": {
"foo": true,
"items": [
{
"foo": 2
},
{
"foo": 1
}
]
},
"cases": [
{
"expression": "&foo",
"error": "syntax"
},
{
"expression": "[&foo]",
"error": "syntax"
},
{
"expression": "{a: &foo}",
"error": "syntax"
},
{
"expression": "foo || &bar",
"error": "syntax"
},
{
"expression": "foo[?&bar]",
"error": "syntax"
},
{
"expression": "length([&foo])",
"error": "syntax"
},
{
"expression": "map((&foo), items)",
"error": "syntax"
},
{
"expression": "map(&&foo, items)",
"error": "syntax"
},
{
"expression": "map(&foo, items)",
"result": [
2,
1
]
},
{
"expression": "sort_by(items, &foo)[].foo",
"result": [
1,
2
]
},
{
"expression": "map(&(foo || `0`), items)",
"result": [
2,
1
]
},
{
"expression": "map(&map(&foo, @), `[ [{\"foo\": 3}] ]`)",
"result": [
[
3
]
]
}
]
}
]