[matt-edmondson]

Fixes #395

What changed

GoGenerator.WriteCondition writes a top-level comparison itself, so it can leave off the outer parentheses that gofmt removes from an if clause. That skipped the operand widening StandardLanguageGenerator.GenerateBinary does everywhere else. So n < limit ? … : … with an int and a long produced if n < limit {, which fails go build with mismatched types.

The non-bitwise BinaryExpression case now computes Promoted(StaticType(left), StaticType(right)), except for shifts and logical operators, which GenerateBinary also excludes. Each operand goes through a new WriteWidenedConditionOperand, which calls GenerateWidenedTo. A struct-literal operand, or a call chain that starts with one, is not a number, so it still goes to WriteConditionOperand. That keeps the #105/#185 parenthesising, and gofmt still has no outer parentheses to remove.

Source	Before	After
int n, long limit: n < limit ? …	if n < limit {	if int64(n) < limit {
int n: n < 0.5 ? …	if n < 0.5 {	if float64(n) < 0.5 {
float n, double limit: n < limit ? …	if n < limit {	if float64(n) < limit {

Tests

• New GoGeneratedSourceCompilesTests.ConditionComparingMixedNumericWidths_Compiles checks the three spellings above, then runs go build and gofmt -l on the output.
• With the generator change reverted, the new test fails.
• Full suite: 1665 passed, 0 failed.

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud