Skip to content

Fix(Novel Arrow): Moved NovelArrow to readNovelFull multisrc - #2620

Draft
D3ICIDE wants to merge 7 commits into
lnreader:masterfrom
D3ICIDE:novelPing
Draft

D3ICIDE wants to merge 7 commits into
lnreader:masterfrom
D3ICIDE:novelPing

Conversation

@D3ICIDE

@D3ICIDE D3ICIDE commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Closes:#2572

#2574 creates its own implementation of readNovelFull instead of using the multisrc.
#2618 I don't even think this works atleast according to my testings and the fact that the site doesn't even use that structure anymore.
Also removed NovelBin plugin

Checklist

  • Update version code if an existing plugin was modified
  • Test changes in Plugin Playground or the app
  • Reference related issues in the PR body (e.g. Closes #xyz)
  • Commit messages follow type(scope): description (e.g. feat(<generator>): add new source)

Copilot AI balanced review requested due to automatic review settings October 1, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Migrates a novel source plugin to a shared template.

This PR should not merge until the replacement can open chapters saved by the old Novel Arrow plugin.

Findings

  1. P1 Saved chapters stop opening ▶
  2. P2 Old filters are unused ▶

Summary

The PR moves Novel Arrow from a standalone plugin into the ReadNovelFull multisource, using https://novelping.com/. It replaces Novel Bin in that source list and updates how AJAX chapter links become paths.

  • Novel Arrow uses the sort/updates listing page and the shared source setup.
  • Novel Bin is removed from the multisource, and Novel Arrow’s icon moves beside its new entry.
  • AJAX chapter links are resolved against the source site.

Reviews (1) · Last reviewed commit: "clean up"

Comment on lines +74 to +75
"id": "novelarrow",
"sourceSite": "https://novelping.com/",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Saved chapters stop opening

The replacement keeps the novelarrow ID, but it cannot read chapters saved by the old plugin. Those chapters have paths like chapter/{novelId}/{chapterId}. The new parseChapter sends each path to novelping.com as a page URL instead of using the old chapter API, so readers may get an empty chapter. Keep support for saved paths or migrate them.

"id": "novelbin",
"sourceSite": "https://novelbin.com/",
"sourceName": "Novel Bin",
"id": "novelarrow",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Old filters are unused

Replacing novelbin leaves filters/novelbin.json behind. The generator looks up filters by the new source ID, so no plugin loads that file now. Remove it so maintainers do not spend time updating unused filters.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@D3ICIDE
D3ICIDE marked this pull request as draft October 1, 2026 10:11
@D3ICIDE

D3ICIDE commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

maybe I shouldn't have removed novelbin(might mess up older downloads), I'll keep this as draft until I know what to do with novelbin and novearrow

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants