Conversation
|
| "id": "novelarrow", | ||
| "sourceSite": "https://novelping.com/", |
There was a problem hiding this comment.
The replacement keeps the novelarrow ID, but it cannot read chapters saved by the old plugin. Those chapters have paths like chapter/{novelId}/{chapterId}. The new parseChapter sends each path to novelping.com as a page URL instead of using the old chapter API, so readers may get an empty chapter. Keep support for saved paths or migrate them.
| "id": "novelbin", | ||
| "sourceSite": "https://novelbin.com/", | ||
| "sourceName": "Novel Bin", | ||
| "id": "novelarrow", |
There was a problem hiding this comment.
Replacing novelbin leaves filters/novelbin.json behind. The generator looks up filters by the new source ID, so no plugin loads that file now. Remove it so maintainers do not spend time updating unused filters.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
maybe I shouldn't have removed novelbin(might mess up older downloads), I'll keep this as draft until I know what to do with novelbin and novearrow |
Closes:#2572
#2574 creates its own implementation of readNovelFull instead of using the multisrc.
#2618 I don't even think this works atleast according to my testings and the fact that the site doesn't even use that structure anymore.
Also removed NovelBin plugin
Checklist
type(scope): description(e.g.feat(<generator>): add new source)