Skip to content

Fix(Novel Arrow): Moved NovelArrow to readNovelFull multisrc #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
D3ICIDE wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fix(Novel Arrow): Moved NovelArrow to readNovelFull multisrc #2620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68454b3
novelping
D3ICIDE Oct 1, 2026
254c93b
novelping 2
D3ICIDE Oct 1, 2026
8d62f0b
switched to multisrc
D3ICIDE Oct 1, 2026
3cf8c1c
clean up
D3ICIDE Oct 1, 2026
0242d5c
moved logo
D3ICIDE Oct 1, 2026
3da72b5
version bump
D3ICIDE Oct 1, 2026
afe131f
clean up
D3ICIDE Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
196 changes: 0 additions & 196 deletions plugins/english/novelarrow.ts
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions plugins/multisrc/readnovelfull/sources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@
}
},
{
"id": "novelbin",
"sourceSite": "https://novelbin.com/",
"sourceName": "Novel Bin",
"id": "novelarrow",

@greptile-apps greptile-apps Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Old filters are unused

Replacing novelbin leaves filters/novelbin.json behind. The generator looks up filters by the new source ID, so no plugin loads that file now. Remove it so maintainers do not spend time updating unused filters.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"sourceSite": "https://novelping.com/",
Comment on lines +74 to +75

@greptile-apps greptile-apps Bot Oct 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Saved chapters stop opening

The replacement keeps the novelarrow ID, but it cannot read chapters saved by the old plugin. Those chapters have paths like chapter/{novelId}/{chapterId}. The new parseChapter sends each path to novelping.com as a page URL instead of using the old chapter API, so readers may get an empty chapter. Keep support for saved paths or migrate them.

"sourceName": "Novel Arrow",
"options": {
"latestPage": "sort/latest",
"latestPage": "sort/updates",
"searchPage": "search",
"versionIncrements": 1,
"versionIncrements": 0,
"customJs": "$('[class*=\"app-promo\"]').remove();"
}
},
Expand Down
6 changes: 3 additions & 3 deletions plugins/multisrc/readnovelfull/template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,9 +692,9 @@ export class ReadNovelFullPlugin implements Plugin.PluginBase {
}

if (chapterHref !== undefined) {
const path = chapterHref.startsWith('/')
? chapterHref.slice(1)
: chapterHref.replace(this.site + '/', '');
const path = new URL(chapterHref, this.site).pathname.substring(
1,
);
tempAjaxChapter.path = path;
tempAjaxChapter.name = initialName;
}
Expand Down
0 public/static/src/en/novelarrow/icon.png → ...ultisrc/readnovelfull/novelarrow/icon.png
View file
Open in desktop
File renamed without changes
Binary file removed public/static/multisrc/readnovelfull/novelbin/icon.png
View file
Open in desktop
Binary file not shown.
Loading