Skip to content

feat(website): Extend acknowledgement text to mention benefit sharing - #7547

Merged
maverbiest merged 8 commits into
mainfrom
update-acknowledgement
Oct 19, 2026
Merged

maverbiest merged 8 commits into
mainfrom
update-acknowledgement

Conversation

@maverbiest

@maverbiest maverbiest commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

To submit to ENA, user must now accept new conditions related to access and benefit sharing: https://www.ebi.ac.uk/abs-dsi/ .

This PR extends our acknowledgement text to reference this.

Screenshot

image

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • [ ] The implemented feature is covered by appropriate, automated tests.
  • [ ] Any manual testing that has been done is documented (i.e. what exactly was tested?)

🚀 Preview: https://update-acknowledgement.loculus.org

@maverbiest maverbiest added the preview Triggers a deployment to argocd label Oct 15, 2026
@claude claude Bot added the website Tasks related to the web application label Oct 15, 2026
@maverbiest maverbiest added preview Triggers a deployment to argocd and removed preview Triggers a deployment to argocd labels Oct 15, 2026
@maverbiest maverbiest removed the preview Triggers a deployment to argocd label Oct 15, 2026
@maverbiest
maverbiest marked this pull request as ready for review October 15, 2026 09:58
@claude

claude Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @maverbiest's task in 30s —— View job


Review

  • Read the diff and the surrounding code
  • Check that existing tests still match the changed text
  • Post the review

This change is small and looks good to merge. I left one optional inline comment about wording and adding a link.

Notes:

  • Tests: The unit tests in SubmissionForm.spec.tsx and the integration test in integration-tests/tests/pages/revision.page.ts:106 find the checkbox by its label. They search for "I confirm that I have the legal right to submit this data", and that text is still in the label, so they should keep passing. I didn't run them. The new paragraph shares the existing checkbox, so no new state or validation is needed.
  • Layout: Switching from items-center to items-start makes sense now that the label has two paragraphs. The checkbox stays next to the first line instead of floating halfway down. The screenshot looks fine.
  • Minor, optional: Each <p> repeats text-xs pl-4 text-gray-500. These classes could go on the wrapping <div> instead.
  • Scope: The acknowledgement section only appears when dataUseTermsEnabled is set (DataUploadForm.tsx:234), not specifically when ENA deposition is on. That matches how the existing INSDC wording works, so nothing new here.

No security or performance concerns.

Comment thread website/src/components/Submission/DataUploadForm.tsx Outdated
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@maverbiest maverbiest added the preview Triggers a deployment to argocd label Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Triggers a deployment to argocd website Tasks related to the web application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants