Repository navigation
feat: render native queries and saved result views - #66
Merged
Merged
Conversation
Add master-compatible list, table, and gallery views for query blocks, tag objects, and property objects with typed edits, local errors, and native mobile controls. Validate full block interactions and destination selection toolbars with 947 core tests, 1113 master conformance cases, and native iOS and Android runtime checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render simple and advanced #Query blocks plus saved List/Table/Gallery views for queries, tag objects, and property objects. Lists reuse ordinary block rendering, breadcrumbs, locally folded children, editing, and selection actions. Query owners remain normal blocks; only their results start collapsed, with no query evaluation until opened.
Use one results/actions toolbar for queries and one saved-tabs/actions toolbar for tag/property collections. A separate native type icon switches List/Table/Gallery; unsaved collections default to All/List. Saved query views are available through that icon's Saved views submenu. Search stays within the collection width, expanded results have a trailing gap, and references retain their existing renderer.
Read/write master-compatible EDN/DataScript settings and use the pinned master filtering/sorting implementation. Support horizontally scrolling editable tables, immediate value selection, explicit creation for open properties, atomic typed edits, conflict checks, and local errors. Filter/sort sheets open partially, expand for longer lists, and preserve the app's dark palette. Task priority icons now open native menus with real graph closed values, selected state, and clearing. Pushed destinations own their selection toolbar. Empty cells have accessible names so the native renderer accepts type changes; the native bridge retains all batches emitted by one flush.
Validation:
Upstream fixes: query literals, filter/sort parity, merged, reference matching and inserted view settings, and native rendering, controls, and sheet themes. LUI documents six pre-existing Android snapshot baseline failures; the four new responsive-control snapshots and this app's native runtime regressions pass. URL scheme restoration is isolated in #67.