Conversation
…V or haplotype data
…V or haplotype data
…is giving some errors for Ag3
…f.py or diagram definition
… for each dataset
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
+ Coverage 88.88% 88.97% +0.09%
==========================================
Files 56 57 +1
Lines 6439 6505 +66
==========================================
+ Hits 5723 5788 +65
- Misses 716 717 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue 1349 - adds missing wgs_run_accessions and wgs_data_catalogue where applicable.
Also solves issue related to Issue 1202 - missing image for darlingi, though that issue mentions minimus and funestus these are present on the live website.
Ran
pre-commit run --all-filesand all passed.Adds visualisation for class hierarchy, with classes unsupported for a dataset greyed out in that dataset's page. A further page showing the deeper structure is also added.
Attached is html directory showing output of
make html,script used to validate whether wgs_run_accessions/wgs_data_catalogue is applicable (N.B. Adar1 produces output for wgs_data_catalogue but URLs are explicitly "dummy" URLs), and spreadsheet indicating how support for each class for each dataset was determined.html.zip
check_wgs_run_accessions_data_catalogue.py
dataset_class_method_support.xlsx