Fix serialization round trip for QuantizationType::SQ without standard deviation - #1461
Merged
Merged
Conversation
Align the serialized spelling for SQ's default standard deviation with the parser's canonical SQ_N form.
SQ_N
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The serialization format now matches the existing parser and is adequately tested.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes SQ_N serialization so scalar quantization configurations without an explicit standard deviation round-trip correctly.
Changes:
- Serializes
SQwithout standard deviation asSQ_N. - Adds formatting and serialization round-trip coverage.
| File | Description |
|---|---|
diskann-disk/src/build/configuration/quantization_types.rs |
Aligns SQ formatting with parsing and updates tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
- Coverage 91.90% 90.86% -1.04%
==========================================
Files 582 582
Lines 114947 114950 +3
==========================================
- Hits 105640 104452 -1188
- Misses 9307 10498 +1191
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
SQ_N
Alex Razumov (arrayka)
marked this pull request as ready for review
October 5, 2026 20:14
Aditya Krishnan (arkrishn94)
approved these changes
Oct 5, 2026
Alex Razumov (arrayka)
enabled auto-merge (squash)
October 5, 2026 21:22
Mark Hildebrand (hildebrandmw)
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
QuantizationType::SQwith no explicit standard deviation did not round-trip through serialization:It serialized as
SQ_N_None, which the deserializer rejected.What
Serialize SQ configs without an explicit standard deviation as
SQ_Nand cover the case in round-trip tests.