Skip to content

Fix serialization round trip for QuantizationType::SQ without standard deviation #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex Razumov (arrayka) merged 1 commit into from
Oct 5, 2026
Merged

Fix serialization round trip for QuantizationType::SQ without standard deviation #1461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions diskann-disk/src/build/configuration/quantization_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,10 @@ impl Display for QuantizationType {
QuantizationType::SQ {
nbits,
standard_deviation,
} => {
let standard_deviation = match standard_deviation {
Some(sd) => sd.into_inner().to_string(),
None => "None".to_string(),
};
write!(f, "SQ_{}_{}", nbits, standard_deviation)
}
} => match standard_deviation {
Some(sd) => write!(f, "SQ_{}_{}", nbits, sd.into_inner()),
None => write!(f, "SQ_{}", nbits),
},
}
}
}
Expand Down Expand Up @@ -281,7 +278,7 @@ mod tests {
#[case(QuantizationType::Spherical(SphericalBits::One), "SPHERICAL_1")]
#[case(
QuantizationType::SQ { nbits: 8, standard_deviation: None },
"SQ_8_None"
"SQ_8"
)]
#[case(
QuantizationType::SQ {
Expand Down Expand Up @@ -331,11 +328,13 @@ mod tests {

#[test]
fn test_roundtrip_serialization() {
// Note: SQ with None standard_deviation is not included as it formats to "SQ_N_None"
// which the parser doesn't accept - this is a known limitation of the current implementation
let types = vec![
QuantizationType::FP,
QuantizationType::PQ { num_chunks: 256 },
QuantizationType::SQ {
nbits: 8,
standard_deviation: None,
},
QuantizationType::SQ {
nbits: 8,
standard_deviation: Some(Positive::new(1.5).unwrap()),
Expand Down
Loading