Add container runtime specs for ACL validation - #81
Merged
Merged
Conversation
Import containerd2 and runc RPM definitions for ACL builds, including the SELinux relabel fix, and register both packages in acl/packages.yaml.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix the %check pipeline so go list ./... failures cannot be masked.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds containerd2 and runc RPM definitions, runtime configuration, patches, signatures, and ACL package registration.
Changes:
- Adds container runtime package specifications and source signatures.
- Includes compatibility, snapshotter, cgroup, SELinux, and CVE patches.
- Registers both packages in
acl/packages.yaml. - Review finding:
runc.specmay maskgo listfailures in%check.
| File | Description |
|---|---|
acl/SPECS/runc/runc.spec |
Defines the runc RPM build. |
acl/SPECS/runc/runc.signatures.json |
Verifies the runc source archive. |
acl/SPECS/containerd2/tardev-support.patch |
Adds containerd tar device support. |
acl/SPECS/containerd2/multi-snapshotters-support.patch |
Adds multi-snapshotter support. |
acl/SPECS/containerd2/fix-wrapped-enotsup-selinux-relabel.patch |
Handles wrapped SELinux relabel errors. |
acl/SPECS/containerd2/fix-TestCgroupNamespace-cgroupv1.patch |
Fixes the cgroup v1 namespace test. |
acl/SPECS/containerd2/CVE-2026-56852.patch |
Applies a containerd security fix. |
acl/SPECS/containerd2/CVE-2026-37236.patch |
Applies a containerd security fix. |
acl/SPECS/containerd2/containerd2.spec |
Defines the containerd2 RPM build. |
acl/SPECS/containerd2/containerd2.signatures.json |
Verifies containerd source archives. |
acl/SPECS/containerd2/containerd.toml |
Configures the container runtime. |
acl/SPECS/containerd2/containerd.service |
Provides the systemd service unit. |
acl/packages.yaml |
Registers containerd2 and runc for ACL builds. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jiri Appl (jiria)
approved these changes
Sep 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import containerd2 and runc RPM definitions for ACL builds, including the SELinux relabel fix, and register both packages in acl/packages.yaml.
Change Log
Type of Change
Does this affect the image build?
Associated Issues
Test Methodology
Merge Checklist
All applicable boxes should be checked before merging