Repository navigation
feat(test-runner): experimental esbuild transpilation - #43320
Pavel Feldman (pavelfeldman) merged 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| .update(pluginsEpilogue.map(p => p[0]).join(',')) | ||
| .update(useDefineForClassFields ? 'define' : 'assign') | ||
| .update(jsx ? JSON.stringify(jsx) : '') | ||
| .update(esbuildVersion ? 'esbuild@' + esbuildVersion : '') |
There was a problem hiding this comment.
NIT: should this also include the node version (see the process.versions.node.split('-')[0] above) so that if the developer switches node without updating playwright we wont attempt to reuse the same code?
Test results for "tests 1"6 flaky53416 passed, 1267 skipped Merge workflow run. |
Test results for "MCP"2 failed 9202 passed, 1495 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟢 The failures are pre-existing flakes; this PR is clearBoth final MCP failures have the same test and error signature on unrelated revisions. The main test workflow had no final failures. DetailsThis PR changes the optional esbuild transform path and does not touch the MCP download or idle-timeout behavior. CI tested merge sha Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
6284a53
into
microsoft:main
Summary
PLAYWRIGHT_EXPERIMENTAL_ESBUILD=1transpiles TS/JS with esbuild instead of Babel; the loader, tsconfig resolution and compilation cache are unchanged.>=0.21.5) that users install themselves.useDefineForClassFieldsthe same way as Babel.assertimport attributes are unsupported in ESM,PW_TEST_SOURCE_TRANSFORMis ignored, the module behavior pinned inbabel.spec.tsdiffers, syntax error messages differ.esbuild
real 0m4.392s
real 0m4.349s
babel
real 0m10.349s
real 0m10.255s
hot
real 0m2.637s