Repository navigation
feat(test-runner): experimental esbuild transpilation #43320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pavel Feldman (pavelfeldman)
merged 2 commits into
microsoft:main
from
pavelfeldman:esbuild-transpilation
Oct 13, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /** | ||
| * Copyright (c) Microsoft Corporation. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import path from 'path'; | ||
|
|
||
| import { libPath } from '../package'; | ||
|
|
||
| import type * as esbuild from 'esbuild'; | ||
| import type { JsxOptions } from './babelBundle'; | ||
|
|
||
| export type Esbuild = typeof esbuild; | ||
|
|
||
| export function loadEsbuild(): Esbuild { | ||
| try { | ||
| return require('esbuild'); | ||
| } catch (error) { | ||
| throw new Error(`PLAYWRIGHT_EXPERIMENTAL_ESBUILD requires the "esbuild" package, install it with "npm install --save-dev esbuild"`, { cause: error }); | ||
| } | ||
| } | ||
|
|
||
| export function esbuildTransform(esbuild: Esbuild, code: string, filename: string, isModule: boolean, useDefineForClassFields: boolean, jsx: JsxOptions | undefined): { code: string, map: any } { | ||
| const options = transformOptions(filename, isModule, useDefineForClassFields, jsx); | ||
| let result: esbuild.TransformResult; | ||
| try { | ||
| result = transformSync(esbuild, code, options); | ||
| } catch (error) { | ||
| throw toSyntaxError(error, code, filename); | ||
| } | ||
| return { code: result.code, map: JSON.parse(result.map) }; | ||
| } | ||
|
|
||
| function transformOptions(filename: string, isModule: boolean, useDefineForClassFields: boolean, jsx: JsxOptions | undefined): esbuild.TransformOptions { | ||
| const ext = path.extname(filename); | ||
| const jsxMode = jsx?.jsx ?? 'react-jsx'; | ||
| return { | ||
| sourcefile: filename, | ||
| loader: ext === '.tsx' ? 'tsx' : ['.ts', '.mts', '.cts'].includes(ext) ? 'ts' : 'jsx', | ||
| format: isModule ? 'esm' : 'cjs', | ||
| platform: 'node', | ||
| target: 'node' + process.versions.node.split('-')[0], | ||
| sourcemap: 'both', | ||
| jsx: jsxMode === 'react' ? 'transform' : 'automatic', | ||
| jsxDev: jsxMode === 'react-jsxdev', | ||
| jsxFactory: jsx?.jsxFactory, | ||
| jsxFragment: jsx?.jsxFragmentFactory, | ||
| jsxImportSource: jsx?.jsxImportSource, | ||
| tsconfigRaw: { | ||
| compilerOptions: { | ||
| useDefineForClassFields, | ||
| alwaysStrict: true, | ||
| }, | ||
| }, | ||
| logLevel: 'silent', | ||
| }; | ||
| } | ||
|
|
||
| function transformSync(esbuild: Esbuild, code: string, options: esbuild.TransformOptions): esbuild.TransformResult { | ||
| try { | ||
| return esbuild.transformSync(code, options); | ||
| } catch (error) { | ||
| // Ctrl+C terminates esbuild's service process along with the whole process group. | ||
| if (!(error instanceof Error) || !/^The service (is no longer running|was stopped)/.test(error.message)) | ||
| throw error; | ||
| void esbuild.stop(); | ||
| return esbuild.transformSync(code, options); | ||
| } | ||
| } | ||
|
|
||
| function toSyntaxError(error: any, code: string, filename: string): Error { | ||
| const message: esbuild.Message | undefined = error?.errors?.[0]; | ||
| if (!message?.location) | ||
| return error; | ||
| const { line, column } = message.location; | ||
| const { codeFrameColumns } = require(libPath('transform', 'babelBundle')); | ||
| const codeFrame = codeFrameColumns(code, { start: { line, column: column + 1 } }); | ||
| const syntaxError = new SyntaxError(`${filename}: ${message.text} (${line}:${column})\n\n${codeFrame}`); | ||
| (syntaxError as any).loc = { line, column }; | ||
| return syntaxError; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: should this also include the node version (see the
process.versions.node.split('-')[0]above) so that if the developer switches node without updating playwright we wont attempt to reuse the same code?