Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
devin-ai-integration
Bot
force-pushed
the
devin/1790751602-gpt-oss-bf16-sampler
branch
from
September 30, 2026 20:25
59e3e78 to
0c3a2ef
Compare
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1790751602-gpt-oss-bf16-sampler
branch
from
September 30, 2026 20:48
0c3a2ef to
07fca4a
Compare
kevintli
added this pull request to stack #13
September 30, 2026 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the gpt-oss preset, the LoRA sampler failed at startup:
openai/gpt-oss-20bships MXFP4 experts, and SGLang routes those throughtriton_kernel. SGLang's LoRA MoE layer only supportstriton(which needsget_triton_quant_info, andMxfp4MoEMethoddoesn't have it) ormarlin(CompressedTensors/NvFp4 only). Miles has the same constraint and says so:examples/lora/run-gpt-oss-20B-megatron-moe-lora.shhas "need to use bf16 ckpt when enable triton moe backend, eg, lmsys/gpt-oss-20b-bf16", and its gpt-oss LoRA CI usesgpt-oss-20b-bf16.Changes:
model_weights: the HF repo for the base weights, defaulting tomodel. The served/client-facingbase_modelis stillmodel; only the downloaded assets change.model_weightsis now part oftrainer_identity()andinference_identity(), so switching weights redeploys both.model_weights = "lmsys/gpt-oss-20b-bf16"(the MXFP4 release upcast to BF16, same architecture and config apart fromquantization_config), plussglang_cfg.moe_runner_backend = "triton".Stacked on #6.
Link to Devin session: https://modal.devinenterprise.com/sessions/f53cfabb210146de8f0338fe388d7973
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/f53cfabb210146de8f0338fe388d7973?variant=devin
Requested by: @kevintli