Conversation
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
devin-ai-integration
Bot
force-pushed
the
devin/1790761839-sampler-path-training-run
branch
from
September 30, 2026 20:25
9ee1d73 to
ce07311
Compare
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1790761839-sampler-path-training-run
branch
from
September 30, 2026 20:48
ce07311 to
93c48ee
Compare
kevintli
added this pull request to stack #13
September 30, 2026 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sampler paths are minted as
tinker://<model_id>:train:0/sampler_weights/<name>(_sampler_model_path), but checkpoint entries are keyed by the baremodel_id. When a user calls the stock cookbook'scheckpoint_utils.get_renderer_name_from_checkpoint_async(service_client, sampler_path), it goes throughrest.get_training_run_by_tinker_path→GET /api/v1/training_runs/<model_id>:train:0, and that request 404s:The cookbook only logs a warning and falls back to the configured renderer, so this does not break anything. It does mean renderer metadata never round-trips for sampler checkpoints (seen with
sec-rl eval --checkpoint <sampler_path>in the sec-search-rl repro).This PR is stacked on #7. It is not deployed to the repro frontends, because redeploying would restart their control planes in the middle of the runs.
Link to Devin session: https://modal.devinenterprise.com/sessions/f53cfabb210146de8f0338fe388d7973
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/f53cfabb210146de8f0338fe388d7973?variant=devin
Requested by: @kevintli