Repository navigation
test: MotionError contract pins the 17 members - #28
Merged
Merged
Conversation
…match and NotAcknowledged fbdd542 appended ProtocolMismatch = 15 and NotAcknowledged = 16 without updating the frozen-ordinals contract test, so master's C# tests have been red since then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Master's C# tests have been red since
fbdd542, which appendedProtocolMismatch = 15andNotAcknowledged = 16toMotionErrorwithout updatingContractSurfaceTests.MotionError_Has…MembersWithFrozenOrdinals….This PR pins the two new members at their committed ordinals, renames the test to "Seventeen", and records the 2026-09-28 addition (generic-axis ADR-12) in the test's comment. No product code changes.
Tests
RocketWelder.SDK.Devices.Motion.Tests: 59/59 pass locally (one failed before this change).Unblocks #27 and the 3.0.0 release.