[drahnr]

Fix clippy findings, and bump codspeed. This resolves the issues observed in #1742

Prequel to #3009 and #2995 and #3012

[codecov-commenter]

Codecov Report

❌ Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.20%. Comparing base (dcdb2b1) to head (4487c6d).

Files with missing lines	Patch %	Lines
src/bin/sccache-dist/build.rs	0.00%	16 Missing ⚠️
src/dist/http.rs	0.00%	5 Missing ⚠️
src/bin/sccache-dist/main.rs	0.00%	4 Missing ⚠️
tests/harness/mod.rs	0.00%	4 Missing ⚠️
src/bin/sccache-dist/token_check.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3013      +/-   ##
==========================================
- Coverage   78.80%   76.20%   -2.61%     
==========================================
  Files          75       75              
  Lines       45355    45314      -41     
==========================================
- Hits        35743    34530    -1213     
- Misses       9612    10784    +1172     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🟢 Approval recommended

The lint cleanups and benchmark workflow update have no active review issues blocking approval.

No open issues 🎉

What changed in this PR

Updates sccache’s distributed compilation code and test helpers to address Clippy warnings, and upgrades the benchmark workflow to CodSpeed v5.

Changes:

• Applies lint-driven syntax and API cleanups across distributed compilation code and tests.
• Removes the from_iter_instead_of_collect lint setting.
• Upgrades the CodSpeed action to v5 and stops suppressing benchmark stdout.

File	Description
tests/​harness/​mod.rs	Cleans up server startup handling, lint annotations, and semicolons.
src/​test/​utils.rs	Uses bracket syntax for vector macros.
src/​dist/​http.rs	Simplifies certificate checks and adds semicolons.
src/​config.rs	Adds a semicolon in a configuration test.
src/​bin/​sccache-dist/​token_check.rs	Combines nested authentication-cache checks.
src/​bin/​sccache-dist/​main.rs	Cleans up scheduler statement syntax.
src/​bin/​sccache-dist/​cmdline/​parse.rs	Uses explicit string cloning and adds a test semicolon.
src/​bin/​sccache-dist/​build.rs	Simplifies sorting, formatting, conditionals, and statement syntax.
Cargo.toml	Removes the from_iter_instead_of_collect lint setting.
.github/​workflows/​benchmarks.yml	Upgrades CodSpeed to v5 and preserves benchmark stdout.

_{Review effort: Balanced}

[codspeed]

Hooray! CodSpeed harness just leveled up!

The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable.

What changed between base and head:

• CodSpeed runner v5 changed how benchmarks are measured (base 4.19.1 → head 5.6.3). View release notes
• Cycle estimation (off → on) changes how benchmark performance is calculated. Learn more about cycle estimation

Re-run the base with the same settings to get a valid performance comparison.

---

_{Comparing bs-clippy-and-ci (6a668d8) with main (59f4c83)}