Skip to content

chore: bump codspeed gha to v5 - #3014

Merged
sylvestre merged 2 commits into
mainfrom
bs-codspeed
Nov 9, 2026
Merged

sylvestre merged 2 commits into
mainfrom
bs-codspeed

Conversation

@drahnr

@drahnr drahnr commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Previously this kept failing silently, the newer version resolves that and also provides for higher bench accuracy.

Prequel to #3009 and #2995 and #3012 and #3013

Copilot AI balanced review requested due to automatic review settings November 9, 2026 09:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the CodSpeed v5 upgrade and benchmark output visibility changes.

No open issues 🎉

What changed in this PR

Updates the benchmark workflow to CodSpeed action v5 to address reported silent failures and improve benchmark accuracy.

Changes:

  • Upgrades CodSpeedHQ/action from v4 to v5.
  • Removes stdout suppression from cargo codspeed run, making benchmark output visible in workflow logs.
File Description
.github/​workflows/​benchmarks.yml Upgrades the CodSpeed action and exposes benchmark command output.

Review effort: Balanced

@drahnr drahnr mentioned this pull request Nov 9, 2026
@codecov-commenter

codecov-commenter commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.81%. Comparing base (06545c1) to head (f968cf0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3014      +/-   ##
==========================================
+ Coverage   78.80%   78.81%   +0.01%     
==========================================
  Files          75       75              
  Lines       45355    45355              
==========================================
+ Hits        35740    35746       +6     
+ Misses       9615     9609       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Hooray! CodSpeed harness just leveled up!

The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable.

What changed between base and head:

Re-run the base with the same settings to get a valid performance comparison.


Comparing bs-codspeed (f968cf0) with main (06545c1)

Open in CodSpeed

@sylvestre
sylvestre merged commit dcdb2b1 into main Nov 9, 2026
102 checks passed
@sylvestre

Copy link
Copy Markdown
Collaborator

Thanks for your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants