Repository navigation
fix: support legacy devices without prodname (2.1.3) - #17
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy Net F/T firmware can omit
prodname, which previously stopped connection before RDT streaming. Synchronize the released netft-cpp 0.3.5 snapshot and prepare 2.1.3, usingATI Net F/Tonly when the product-name element is absent. Sensor calibration remains mandatory, and present invalid names still fail.Validation: verify the controlled snapshot and release metadata; retain the existing required platform, CI and security checks. The upstream change passed 77 discovery/parser tests and 9 stream tests, including HTTP discovery through calibrated RDT delivery. A Nano25 connected at 192.168.1.1 was then verified with the fixed SDK: firmware 2.2.56, no prodname in its real XML, 3,483 received records and 50 calibrated samples, zero invalid samples/status/errors/loss/reconnects. All 64 compared configuration fields were unchanged; no bias or configuration write was performed. The real Viewer 0.2.3 companion also completed Connect, 1,184 calibrated samples and Disconnect; its embedded SDK identity matched the released source, and all 64 configuration fields remained unchanged. ROS #20 itself remains unchanged.