discord_pr: render a reopened PR, and say so when an action is dropped - #11
Merged
Merged
Conversation
Consumers have been sending `reopened` since novem-code/gaia#4009 landed on 2026-08-28. The composer had no branch for it, so it fell to the else and set send=false — a workflow run per reopen, saying nothing, going green. Measured on gaia, same commit two minutes apart: `closed` sent, `reopened` skipped. Three of its PRs were reopened in one day and the channel still shows all three as closed. Draft-aware like `opened`, because a PR can be reopened while it is still a draft and "please review" about a draft is what that split exists to avoid. The else now emits a ::warning:: rather than a plain log line. The job still succeeds — a missing message must not fail someone else's pipeline — but the run names the action it dropped. That branch is how this stayed broken for a fortnight after consumers started sending the event, and it will hide the next one the same way. This repo also subscribes to `reopened` for its own PRs now, which it could not usefully do until the composer knew the action. Verified by running the decision chain against every action this file subscribes to, plus an unsubscribed one: seven paths, the two new draft variants among them, and the warning on `locked`.
This was referenced Sep 12, 2026
bjornars
added a commit
to novem-code/novem-python
that referenced
this pull request
Sep 12, 2026
The message composer upstream had no branch for `reopened` and dropped every one — a workflow run per reopen, green, saying nothing. Fixed in novem-code/github-actions#11; pinning by ref means it arrives only when the ref moves. Bumps to 7d5ccc2, the current github-actions main, and adds any event types this repo was missing so the notifications match the rest of the org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9. Stacked on #10 — both touch
discord.yml, so this targets that branch rather than main.Consumers have been sending
reopenedsince novem-code/gaia#4009 landed on 2026-08-28. The composer had no branch for it, so it fell to theelseand setsend=false: a workflow run per reopen, saying nothing, going green. Measured on gaia, same commit two minutes apart —closed→send=success,reopened→send=skipped. Three of its PRs were reopened in one day and the channel still shows all three as closed.Three hunks, and the middle one is the one I would argue about:
The
reopenedbranch, draft-aware likeopened, because a PR can be reopened while still a draft and "please review" about a draft is what that split exists to avoid.The
elsenow emits a::warning::instead of a plain log line. The job still succeeds — a missing message must not fail someone else's pipeline — but the run names the action it dropped. That branch is how this stayed broken for a fortnight after consumers started sending the event, and it will hide the next one identically. If you would rather not have warnings on runs that are working as intended, this hunk is separable; I think the fortnight argues for it.This repo subscribes to
reopenedfor its own PRs, which it could not usefully do until the composer knew the action.Verified by extracting the decision chain and running it against every action this file subscribes to plus an unsubscribed one — seven paths including both new draft variants, and the warning firing on
locked. Ordering is unchanged for merged PRs: aclosedevent still falls through to thePR_MERGEDcheck first.