Skip to content

discord_pr: render a reopened PR, and say so when an action is dropped #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjornars merged 1 commit into from
Sep 12, 2026
Merged

discord_pr: render a reopened PR, and say so when an action is dropped #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/discord.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
types:
- opened
# - synchronize
- reopened
- closed
push:
branches:
Expand Down
17 changes: 16 additions & 1 deletion .github/workflows/discord_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,17 @@ jobs:
ACTION_ICON="<:devpropened:1275356590316322858>"
ACTION_TEXT="has been opened. Please review!"
fi
elif [[ "$EVENT_ACTION" == "reopened" ]]; then
# Draft-aware like `opened` above: a PR can be reopened while it is
# still a draft, and saying "please review" about a draft is the
# thing the split exists to avoid.
if [[ "$PR_DRAFT" == "true" ]]; then
ACTION_ICON="📝"
ACTION_TEXT="draft has been reopened."
else
ACTION_ICON="<:devpropened:1275356590316322858>"
ACTION_TEXT="has been reopened. Please review!"
fi
elif [[ "$EVENT_ACTION" == "ready_for_review" ]]; then
ACTION_ICON="<:devpropened:1275356590316322858>"
ACTION_TEXT="is ready for review!"
Expand All @@ -70,7 +81,11 @@ jobs:
ACTION_ICON="<:devprclosed:1275356586218356776>"
ACTION_TEXT="has been closed!"
else
echo "Unhandled event type. Exiting."
# A warning, not just a log line: this branch is how `reopened`
# stayed broken for a fortnight after consumers started sending it.
# The job still succeeds — a missing message must not fail someone
# else's pipeline — but the run now says which action it dropped.
echo "::warning::discord_pr: no message for event action '$EVENT_ACTION'; nothing sent"
echo "send=false" >> "$GITHUB_OUTPUT"
exit 0
fi
Expand Down