Repository navigation
ci: scope docs quality checks with native paths - #1389
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe pull request adds workflow syntax validation and a script that identifies documentation-related changes. The Mintlify quality checks now run only when the script reports documentation changes. ChangesDocumentation Quality Workflow
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Workflow as mintlify-quality.yml
participant Tests as Node test runner
participant Scope as docs-check-scope.mjs
participant Git
participant Mintlify as Mintlify quality checks
Workflow->>Tests: Run npm run test:workflows
Workflow->>Scope: Pass event name and revision SHAs
Scope->>Git: Diff the selected revision range
Git-->>Scope: Return changed paths
Scope-->>Workflow: Set docs_changed output
Workflow->>Mintlify: Run checks when docs_changed is true
Merge Risk: ⚪ Minimal · up to
|
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Deleting or moving required website files can skip the existing boundary-preservation checks.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Reduces unnecessary docs-quality runs while preserving the required check and always validating workflow syntax.
Changes:
- Adds docs-impact classification using PR and push comparison ranges.
- Gates the full docs suite while retaining workflow syntax checks.
- Adds regression tests and documents the scoping policy.
| File | Description |
|---|---|
scripts/workflow-syntax.test.mjs |
Validates workflow YAML and shell syntax. |
scripts/README.md |
Documents check scope and regression commands. |
scripts/docs-check-scope.test.mjs |
Tests classification, comparison ranges, and workflow gates. |
scripts/docs-check-scope.mjs |
Determines docs impact and reports run decisions. |
package.json |
Adds the workflow regression command. |
.github/workflows/mintlify-quality.yml |
Always validates workflows and conditionally runs docs checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep native docs path filters and run the existing site-preservation test on every PR. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Summary
Use GitHub's native
pathsfilters with directory-wide patterns to scope docs quality checks.src/**,scripts/**,tests/**,patches/**, and.github/workflows/**trigger the suite, along with listed root dependencies/configuration. Blog and static-asset-only changes skip it.Test deployment. No new custom workflow test suite.Keep the path-filtered docs-quality status optional so skipped runs do not block merges.
Context
Follow-up to #1388. The original YAML failure is already fixed on
docs-next; this PR scopes CI while retaining the existing file-preservation safeguard.