Repository navigation
fix(verify-release): judge the repository by its signed index, and retry the byte fetch - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release #18→v0.2.8's automaticverify-releasefailed withapt 仓库发的 deb 与 release 不是同一份, the same message as before I added the wait step. I then measured the live state:They agree, so the repository was not actually out of step — the verdict was being taken from a single
apt-get downloadinside a container, i.e. from one transient fetch. That is a bad judge: it has no retry and it reports a network hiccup as a packaging defect.The verdict now has two independent halves, both retried:
SHA256:for this version indists/stable/main/binary-amd64/Packagesmust equal the release's checksum (up to 10 tries, 20 s apart). The index is what the repository promises, and it is GPG-signed.apt/dnfclient downloads stay as evidence that a real client installs it, and their hashes are printed in the summary table instead of deciding the outcome.Local check of (1) against live data: ✅ equal. Local check of (2): my proxy moved 4.8 MB of the 45.7 MB in 240 s and I killed it — the byte fetch is what the runner does, with a sane network.