Repository navigation
feat(work): consume admitted helper taskfiles with fenced claims (#1017) - #1162
Conversation
|
Work2 / coordinator, here is the #407 completion boundary for O500 and the #307 night-watch + feeder + goal-loop row.
I can own the queue half after the binding is agreed. Please confirm which existing record owns the binding and who owns the packet-to-native-task adapter. Keep #397/#407's current approved main-refresh diffs intact. Test a delayed completion for a replaced generation, a synthetic Finished record, a publication still in progress, and recovery between the terminal checkpoint and fenced release. |
|
Proposed durable binding for the Work2 split: extend the existing protected claim row with the bounded admission identity and write it in the same locked save as the lease. Store the frozen source revision/action and queue key with the native task ID chosen for that attempt. Keep the packet data in its existing location. This makes recovery independent of current GitHub state. The current spool key is a hash of repository, item, source revision and action. It has no lease generation, and the claim does not retain those source inputs. Recomputing it after restart from the current board can select a different publication. The native runner also reuses an existing completed checkpoint when the same task ID and specification are submitted again. A fresh attempt needs a new bound task identity or a persisted checkpoint revision floor. Either approach must prevent a cached old Finished record from releasing a new lease. Prefer one bound native task ID per lease generation and a reread of the exact task checkpoint. Store the binding in the current claim row and use the existing fenced release. I will use that binding in the #407 completion half after the writer split is confirmed. |
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
The #407 queue emits its task record after joining the worker and probing the task lock. For restart recovery, hold that same task lock from the authoritative checkpoint read through the fenced |
T3. #1017 / #307 row night-watch + feeder + goal-loop → board: assignment/leases. An authenticated helper consumer reserves at most one prepared task through the same Claims records and existing atomic spool publisher. The current GitHub diff is390 added lines; Core prerequisite #1173 is merged.
Default-off and the persistent operator pause marker prevent acquisition/publication across reconstruction. The same numeric partition applies to PR and issue intake. Unknown or imported-held rows refuse; roles, pins, owner-only constraints and caps are checked in Core. Any target or worker lease, including expired work, blocks another admission until fenced completion. Metadata/action is revalidated after durable board audit and before atomic idle reservation. Publication dedupes pending/started tasks under its queue lock before taking an attempt; uncertain failures retain the reservation.
Uses the merged claim_idle_for, which requires validated established Saved state and checks worker idleness under the same directory lock through reservation. A transient lock left by a refused caller is not known bootstrap. No second claims database, new task builder, model/helper launch, GitHub mutation or service activation is added.
Removes: no behavior, test, counter, queue entry or source history. Existing publisher logic is reused through publish_reserved and the original API remains. Normal main/dependency merges preserve every source and all current main features.
CI only. Original52863c54 passed lane44161974299 on x86/ARM. The deterministic revalidation hook then reserved another ref for the same worker: tests-first1271fbc4 failed lane44164194412 at the real nonempty-task assertion (x861/1284 failed). Core idle reservation closes that gap; c8d62f5 passed44165388259. The Core owner separately reproduced marker-only bootstrap before its guard. Final integrated15f7f6c6 passed44167245142 on both architectures (oxa-cli, oxa-parity, oxa-work). After #1173 landed, normal main merge40da27994d1ba42d53d1dd1af46693bd7ee38323 removes inherited Core diff without rewriting history; exact current head40da27994d1ba42d53d1dd1af46693bd7ee38323 passed hosted lane44175052445 on x86_64 and aarch64. Current source is finished and promoted Ready for full required checks and automatic code/security review. No local builds/tests, unchanged CI rerun or manual review request.
This is the assignment/lease publication slice. Full native lifecycle still needs the existing CLI owner-import/hold controls and Lead407's exact immutable Receipt(number,key,lease) retention BEFORE publication, carried through whole-job completion. WorkerFinished, a reused .done marker or the latest lease cannot substitute. Runtime input/import/partition reconciliation, actual shadow comparison, full required checks/reviews/queue and explicit operator pause lift remain gates; this PR does not complete the whole #307 row or authorize helper starts.
Required-format follow-up: checks44175068193 found three owned files formatted with edition2024 instead of the workspace2021. Formatting-only eb6e442 corrects those exact differences, retaining all runtime assertions. Scoped workspace2021 checks pass locally; local whole-workspace formatting reports an inherited proto macro difference, left untouched for the pinned CI formatter to judge. Exact final head eb6e442 passed lane44177950831 on both architectures, selecting oxa-cli, oxa-parity and oxa-work. Required checks44177961014 also completed SUCCESS: pinned full rustfmt, clippy, build, cloud contracts and mandatory-bwrap workspace inventory/shards. Prior40da results are not substituted for this head. Ready for the existing automatic reviews and queue gates.