Repository navigation
Feature A: Retain original native attempt bindings in Claims (#1017) - #1220
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Work1 — Lead's caller is composed locally against |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Core binding API merged as This completes the Core API slice for Feature A and #307's assignment/leases + task-publication row. Caller integration, trusted whole-task completion and activation remain separate gates; this API alone does not complete the full board row. Lifecycle corrections #1043 and #1097 remain in qualification. No helper activation is included. |
Feature A (#1214), native board #1017. Ports #307's claims/assignment/leases and task packet/publication row. Review tier: T3.
The native refill path must retain its original reservation before making a task ready. Add
board::NativeBinding::newandClaims::{bind_native,native_binding}to persist the original item number, queue key, complete lease, exact native task ID and Prepared branch in the existing protected Saved assignment row. The constructor centralizes the generation-specific task ID agreed in the completion contract.Binding authenticates the holder and compares every lease field under the existing Claims directory lock. Retries with the identical binding do not rewrite state; competing bindings and task/branch collisions are refused. Released bindings retain their original receipt; a new admitted generation clears the old binding. Missing optional fields remain backward compatible, while malformed saved bindings fail closed. Generic claim_for admission, attempt accounting and release_for fencing remain unchanged.
Work2 owns the mandatory Consumer pre-hardlink callback; Lead407 owns trusted terminal evidence and completion under the native task lock. This PR exports their Core seam; it does not activate refill or claim the whole native board row is complete. API proposal.
Preserves #1173's original commits through a normal history merge on the existing
agent/1017-idle-worker-claimsbranch. The test fixture conflict keeps main's PrivateDir migration and every existing assertion. No new branch, no history rewrite.Validation: configured rustfmt and git diff --check pass; no local builds/tests. Eight behavioral tests cover durable reopen/idempotence/immutability, every full-lease CAS component, authenticated holder, stale completion after replacement, exact task/branch lookup, legacy/malformed saved rows, concurrent contenders, cross-item identity/branch conflicts and failed writes retaining the reservation without refund. An initial fixture used the valid Git branch
invalidas its malformed value; the correctedbad..branchfixture preserves every check and adds a field diagnostic, with no product/API change.Exact head
e7866a56cc47cc55375d7460db5e434499b32f67:oxa-cli,oxa-parity,oxa-work.The merge queue remains the integration gate. Completion requires the actual merged commit.