Skip to content

feat(lead): link board items to bounded read-only details (#1030) - #1232

Open
oxa-agent[bot] wants to merge 10 commits into
mainfrom
agent/1030-item-details
Open

oxa-agent[bot] wants to merge 10 commits into
mainfrom
agent/1030-item-details

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Feature D (#1214); refs #1030's approved v2 design. Ports #307 row digest + attn-watch (acceptance). T3 for finite item routing at the existing authorized boundary.

Board item links open server-rendered /items/{number} with the observed next action, release priority, lease and attempt count from the same borrowed native Board. Item detail keeps Board selected and supports fragment refresh. Titles, checks, findings and diffs remain explicitly unavailable until native observations supply them. Canonical positive u64 IDs only; raw heads and payloads are never rendered. Lease formatting is shared with the board table. No new producer, store, source read, GitHub call, write handler or activation.

Removes: nothing. Own diff: 103 changed lines in four files. Private mock uncommitted; helpers paused. All original Item and main Chat controls retained, Chat before item fixture writes so its zero-count assertion remains valid.

Before 70e4537 failed lane44195055902 on both architectures. Failed-job134434283960 tail confirmed 1,279/1,280 passing with the sole real-listener control missing the new item link. Controls cover real item link/detail, observed fields, Board selection, canonical/overflow/path refusals, unknown item, private-head omission and hostile Host denial.

Historical source head 8ff6f0a normally merged main0095e879 after a verified actual conflict, preserving both Item and main Chat/Prompt/compose APIs and every test. It passed lane44206150317 on both x86_64 and ARM64 (oxa-cli/parity, plan134472482301), full required44206159090 including both mandatory-bwrap partitions/inventory/gate, and exact code review.

The subsequent integrated run44207927880 FAILED at immutable merge-group tree36616da4d78a2813b5b81cec7fb759e703b39ac1. Failed shard134481410047 tail100 shows 2,382/2,383 passing and the sole live-server Item /items/17 response-status assertion at line178 failing. It prints only the path, not the returned status. Every lead product file and the complete live-server test at that merge tree were compared with8ff6f0af and are byte-identical. Primary still reports sourceMERGEABLE/CLEAN; no actual source conflict or already-fixed-on-main criterion is proven, so no speculative main merge or product/auth change.

Current head 14b988f strengthens the Item response assertion from a200 prefix to the exact HTTP/1.1 200 OK status. A failure now reports the bounded status line; it logs no body, headers, credentials or private input. All authorization/refusal assertions are preserved. This is diagnostic qualification work, not a claimed fix for the integrated failure. Fresh automatic component/required CI and current independent review are required;8ff greens are historical. Normal queue integration must establish the outcome. No local builds/tests, empty commit, Ready toggle, manual dispatch, CI restart or enqueue request.

Fresh automatic exact14b988f4 qualification: lane44210327774 and required44210332953, each with one120-second observer. Product is unchanged; an integrated verdict is still required.

@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 17, 2026 23:18
@n0rpan

n0rpan commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T00:21:06.325162Z 8ff6f0a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 07db10f6e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 17, 2026
@oxa-orchestrator

Copy link
Copy Markdown

st merge-flow>author #123207db10f queue=REJECTED run=? next=refresh-on-main note="Composition with current main failed; rebase/merge main, fix, push; a new head needs a new verdict."

see run log

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 8ff6f0af9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 18, 2026
@oxa-orchestrator

Copy link
Copy Markdown

st merge-flow>author #12328ff6f0a queue=REJECTED run=44207927880 next=refresh-on-main note="Composition with current main failed; rebase/merge main, fix, push; a new head needs a new verdict."

FAIL [   0.219s] ( 178/2383) oxa-cli::lead_serve real_server_is_user_enabled_authorized_and_rereads_private_board

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant