Skip to content

Feature A / #307 merge-flow — decode verified JUnit failure names - #1277

Merged
oxa-orchestrator[bot] merged 1 commit into
mainfrom
agent/307-junit-failure-evidence
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 1 commit into
mainfrom
agent/307-junit-failure-evidence

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Scope

Feature A (#1214), #307 merge-flow row. T2. Based on landed archive verification #1246 and synthetic fixture #1269. The board needs actual failed test identities before it can qualify a rejection notice.

The existing opt-in report policy decodes JUnit only after verifying the Actions artifact size and SHA-256 for the rejected merge-group commit. It retains failed or errored test identities alongside the digest, bounds archive decoding and retained names, and reuses a verified report only while that PR’s removal, group, and check-suite identities still match. A digest-valid malformed ZIP leaves the owner journal unchanged. The author-notice adapter remains a separate follow-on. This change adds no GitHub write path or receipt.

Verification

Formatting and diff whitespace passed. Fixtures cover passing versus failed test cases, invalid archive and XML shapes, digest-valid malformed ZIP refusal, and exact group/check-suite cache identity. On 7fba2eff, required checks passed both mandatory sandbox partitions and the inventory gate. The x86_64 and ARM64 lanes passed 4,864/4,864 tests each and ran the decoder, exact-attempt, and CLI artifact controls. CodeQL passed. Exact-head Codex code and security reviews reported no findings. Integrated checks started normally on merge-group head ce5cb040.

Landed at ce5cb0409b530fbe6a14698c93dc660f285f9a9e. The exact integrated checks passed both mandatory sandbox partitions and the inventory gate. The read-only notice projection follows in #1281.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T02:38:50.594774Z 7fba2ef Manual request
🔒 Security Review ✅ Completed 2026-11-18T02:40:16.174575Z 7fba2ef Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 7fba2effb6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 7fba2effb6

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit ce5cb04 Nov 18, 2026
33 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/307-junit-failure-evidence branch November 18, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant