Repository navigation
Feature A / #307 merge-flow — decode verified JUnit failure names - #1277
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Scope
Feature A (#1214), #307 merge-flow row. T2. Based on landed archive verification #1246 and synthetic fixture #1269. The board needs actual failed test identities before it can qualify a rejection notice.
The existing opt-in report policy decodes JUnit only after verifying the Actions artifact size and SHA-256 for the rejected merge-group commit. It retains failed or errored test identities alongside the digest, bounds archive decoding and retained names, and reuses a verified report only while that PR’s removal, group, and check-suite identities still match. A digest-valid malformed ZIP leaves the owner journal unchanged. The author-notice adapter remains a separate follow-on. This change adds no GitHub write path or receipt.
Verification
Formatting and diff whitespace passed. Fixtures cover passing versus failed test cases, invalid archive and XML shapes, digest-valid malformed ZIP refusal, and exact group/check-suite cache identity. On
7fba2eff, required checks passed both mandatory sandbox partitions and the inventory gate. The x86_64 and ARM64 lanes passed 4,864/4,864 tests each and ran the decoder, exact-attempt, and CLI artifact controls. CodeQL passed. Exact-head Codex code and security reviews reported no findings. Integrated checks started normally on merge-group headce5cb040.Landed at
ce5cb0409b530fbe6a14698c93dc660f285f9a9e. The exact integrated checks passed both mandatory sandbox partitions and the inventory gate. The read-only notice projection follows in #1281.