Skip to content

Feature A / #307 merge-flow — project exact rejection notices in shadow - #1281

Merged
oxa-orchestrator[bot] merged 1 commit into
mainfrom
agent/307-shadow-rejection-notices
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 1 commit into
mainfrom
agent/307-shadow-rejection-notices

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Scope

Feature A (#1214), #307 merge-flow row. T2. Based on the landed JUnit decoder #1277. The default-off landing shadow can now project an author notice when the owner journal records a matching admission and verified reports identify the failed tests on the removed merge-group commit.

The proposal carries the exact PR head, merge-group head, and removal event. Its recipient comes from the same authenticated PR row. Recipient identity is kept out of raw rejection rows. Current queue membership, missing author identity, or incomplete artifact coverage suppress the proposal. Existing latest-review holds still govern landing. The shadow adds no GitHub mutation or delivery or retry receipt.

Verification

Formatting and diff whitespace passed. On ac664cf5, required CI passed both mandatory sandbox partitions and the inventory gate. The x86_64 and ARM64 lanes passed 1,573/1,573 tests each, including the CLI report and review-hold fixtures, recipient identity, and owner-journal admission matching. CodeQL passed. Exact-head Codex code and security reviews reported no findings. Fixtures cover distinct recipients and removals for two PRs sharing verified artifact bytes, missing recipients, current and malformed queue observations, raw artifact collection with the notice path off, and a mock transport that rejects writes.

Landed at c7bfd2a11481ab7070edefd3af314e8296478b95. Exact integrated checks passed both mandatory sandbox partitions and the inventory gate. The integrated logs confirm the read-only CLI report-to-notice fixture, review hold, recipient identity, and owner-journal matching. Delivery and retry still require authentic receipts.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T03:03:55.298309Z ac664cf Manual request
🔒 Security Review ✅ Completed 2026-11-18T03:05:58.841703Z ac664cf Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: ac664cf563

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: ac664cf563

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit c7bfd2a Nov 18, 2026
31 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/307-shadow-rejection-notices branch November 18, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant