Repository navigation
Feature A / #307 merge-flow — project exact rejection notices in shadow - #1281
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Scope
Feature A (#1214), #307 merge-flow row. T2. Based on the landed JUnit decoder #1277. The default-off landing shadow can now project an author notice when the owner journal records a matching admission and verified reports identify the failed tests on the removed merge-group commit.
The proposal carries the exact PR head, merge-group head, and removal event. Its recipient comes from the same authenticated PR row. Recipient identity is kept out of raw rejection rows. Current queue membership, missing author identity, or incomplete artifact coverage suppress the proposal. Existing latest-review holds still govern landing. The shadow adds no GitHub mutation or delivery or retry receipt.
Verification
Formatting and diff whitespace passed. On
ac664cf5, required CI passed both mandatory sandbox partitions and the inventory gate. The x86_64 and ARM64 lanes passed 1,573/1,573 tests each, including the CLI report and review-hold fixtures, recipient identity, and owner-journal admission matching. CodeQL passed. Exact-head Codex code and security reviews reported no findings. Fixtures cover distinct recipients and removals for two PRs sharing verified artifact bytes, missing recipients, current and malformed queue observations, raw artifact collection with the notice path off, and a mock transport that rejects writes.Landed at
c7bfd2a11481ab7070edefd3af314e8296478b95. Exact integrated checks passed both mandatory sandbox partitions and the inventory gate. The integrated logs confirm the read-only CLI report-to-notice fixture, review hold, recipient identity, and owner-journal matching. Delivery and retry still require authentic receipts.