Repository navigation
Feature C — Verify staged Lead steering survives Session compaction (#1199) - #1296
Merged
Merged
Conversation
Collaborator
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature C · #1199 · #307 row
codex-send/bridge· T1#1282's landed CLI test covers a killed in-flight turn, reopening the original goal, exact ask/reference/lease fields, and a single saved steering append. Its Session compaction test exercised the same durable record with an empty pending-steer slot.
Extend the existing Session compaction/reopen test with a pending steer bound to a lease. The full goal comparison now includes the reserved entry ID, revision, exact multiline steer, holder and generation, plus distinct asks and two standing references. The transcript and fork privacy checks still run. This changes one Session test file, disjoint from Work1 #1265 and Work2 #1267.
79ba5296and passed 2,909 tests on each architecture with the three existing opt-in skips. x86_64 receipt · ARM64 receipt5ebc8236. Merge-group test receipt