Repository navigation
Feature C: Preserve native worker launch identity in the task checkpoint (#1199) - #1317
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
T2. Feature C, #1199 and #307 row night-watch + feeder + goal-loop: board assignment/leases, alongside codex-send / bridge for exact runner evidence.
A future per-lease signal needs an identity for the actual worker invocation. The same Session ID can resume across launches, and checkpoint replay can expose the same result again. The native runner now captures the already durable revision just before starting a worker and records it with that invocation's result in the existing task checkpoint. The runner supplies the value. Legacy checkpoints keep loading, and ordinary non-native launches omit it. The existing checkpoint reader rejects impossible revisions.
This is the producer side of the agreed #1311 contract. No Claims or observation writer is added here. The existing accounting flow, child result protocol, and hosted assignment/activation gates remain intact. No behavior removed.
Controls exercise the real native refill and execution CLI, including preservation of the full checkpoint after replay. A durable checkpoint regression also replays an unacknowledged worker result and verifies its original launch identity. Scoped formatting and whitespace checks passed locally. Hosted selected CI and draft checks are pending.
Exact head
d6d81767cf99bc0d7abe68a5841267ca8156fda5passed selected hosted CI and draft checks. Both architectures passed all 1,599 tests with zero skips, including the named real native refill-to-completion test and durable worker-receipt replay test. Required Ready checks and current-source review follow.Exact required Ready checks passed on
d6d81767. The current-source code review reports no issues. The security receipt has yet to report a finding verdict. The read-only merge preview against landed #1311 at8c27af13is clean.