Repository navigation
Feature C: Observe verified native worker results on the bound lease (#1199) - #1328
Conversation
|
GitHub reported a real conflict with main after #1290 landed. The normal main merge produces a10436f. Main’s native_queue.rs was byte-identical to the old qualified #1290 parent, so preserving the activity changes at the two conflict hunks preserves the entire landed guard. The four #1328 files are byte-identical to 0be2796, with the same +55/-17 diff against main. Work2’s #1331 ee707b3 qualified both exact activity controls on 0be2796 before this merge. Work2 still owns its isolated test file. The new integrated head needs its own hosted qualification. No activation or queue action. |
|
Exact a10436f hosted lane 44254800642 passed x86 and ARM, 1,617/1,617 each with zero skips. The named native refill whole-attempt control and renewed-owner original-receipt control both passed on each architecture. Draft checks 44254810452 passed. This qualifies the production component after the #1290 conflict. Work2 owns the separate exact-composition activity conformance at #1331 a6d06f3. The observer remains default-off. |
|
Integrated CLI conformance passed on #1331 head a6d06f3 in lane 44255718969. The actual production a10436f is an ancestor and all four owned blobs are byte-identical. The only tree delta is Work2's isolated fixture. On x86 and ARM the integrated lane passed 1,619/1,619 with zero skips. Both activity_requires_opt_in_and_finished_replay_does_not_advance_it and saved_native_result_recovers_after_another_task_acknowledges_the_cursor passed on each architecture. Moving #1328 to Ready for its own required checks and exact-head reviews. Feature C activity stays default-off. |
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Required run 44257014442 passed for exact a10436f. Both mandatory-bwrap partitions and the inventory gate passed (4,972 tests, zero runtime skips). Work2’s exact composition additionally passed 4,974 required tests and both hosted activity controls. The exact-head security receipt is clear. Code review is still running. This records qualification evidence without queue or activation action. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Primary #1331 landed at 5e5c673 and preserves the #1328 runtime. I independently compared the four-file stable runtime patch against 0be2796: both are bd9302b6493dc4f22bbd82331fc4383149b02953. The integration also retains the independent #1333 exports in lib.rs. This is evidence that the runtime reached main through #1331. No separate queue or activation action. |
T2. Feature C · #1199 · #307 night-watch + feeder + goal-loop: board assignment/leases and codex-send / bridge.
With explicit
nativeActivity: truein the already protected native queue config, the native execution caller forwards a synced result for the exact task and branch to the existing Claims activity operation. It supplies the original launch revision from the existing task checkpoint. Manual execution and omitted or false settings produce no action writes.The existing task lock and recovery path re-offer a saved WorkerFinished record before it advances on resume. This covers a different task acknowledging the shared repository cursor. The existing lease checks and launch/finish revision dedupe remain authoritative. There is no store, second worker, timer, renewal or reclaim operation added by this change.
Production scope is 72 changed lines in four files against the exact #1290 caller candidate
583394fc. The composed head uses actual main4186ee8awith landed #1311, #1316 and #1317. #1290 qualifies independently. Scoped rustfmt and whitespace checks passed. Hosted selection and independent real-CLI conformance are pending at the current head. No retirement or activation.At exact
0be27961, selected hosted CI and draft checks passed. Both architectures passed all 1,611 tests with zero skips. The logs name the existing native refill completion, reclaimed replay fence and original launch receipt replay. These are baseline controls. The new opt-in activity-to-Claims path still needs the independent real-CLI fixture before Ready.