Skip to content

test(work): qualify native activity forwarding and recovery - #1331

Merged
oxa-orchestrator[bot] merged 11 commits into
mainfrom
agent/1199-native-activity-controls
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 11 commits into
mainfrom
agent/1199-native-activity-controls

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

T3 composition while the host-launch dependency is present; own changes are test-only. The independently owned #1290 host caller and #1328 runtime adapter retain their normal review gates. #1199, #307 night-watch + feeder + goal-loop: board assignment/leases and codex-send / bridge.

Extend only the existing isolated work_native_lifecycle.rs agreed in Lead's contract. The original #1307 branch/qualification stays frozen. Lead owns the production observer, host caller and checkpoint code; Work1 owns Claims activity; this PR adds no production writer or new authority.

  • Real managed CLI controls require opt-in: omission and explicit false leave Claims activity absent. True retains the original full lease generation and binding, records the actual runner launch identity, keeps action finish between launch and whole-task finish, emits no heartbeat, and leaves action/model use unchanged on released replay.
  • The recovery control makes only its synthetic Claims directory read-only, so the actual result is synced before the observer's durable write fails. It restores the directory, verifies the retained original lease and WorkerFinished checkpoint, and runs a different ordinary task against the same repository cursor. After that task acknowledges the pending foreign result, native resume must re-offer its saved process result without invoking the model, preserve its original launch/finish/time, and settle the same original binding.
  • Existing expiry, renewed original-receipt settlement, verified-gone reclaim, stale started-packet and no-model replay controls remain.

Tests use real child binaries, the existing cleared TestEnv, local Git and FakeServer. No real network, key, timer, PID inference, helper start or activation.

Tests-first baseline is the actual consumer parent05deb7fd62b0aa6d810a2a67e3b55bedbaff68f9, which has the landed Core activity and launch-revision producer but no action observer. The hosted baseline44251175722 completed with both architectures running1,410 tests:1,408 passed and only the two new runtime controls failed, zero skips. Enabled execution reached completion without a Claims action; recovery observed task_transition rather than the expected retained worker_finished. These are real runtime assertions, not compile failures.

After consuming that baseline, composed exact unchanged runtime0be27961da39f703c3ba2593a31027bbe608e1d2 from #1328 in ee707b3. All four production files match the owner ref byte-for-byte, and the test file matches52551540 byte-for-byte. Hosted after lane44252791633 completed SUCCESS on this exact head. Both architectures ran1,613 tests:1,613 passed, zero skips. Both new runtime controls, the existing reclaim fence and real native completion control explicitly passed. Selected crates: oxa-cli, oxa-parity and oxa-work.

Scoped rustfmt and git diff --check passed. No local compiler/tests. Exact before5255154073c999c008e916495854d791478f06d1 is qualified negative evidence; exact after ee707b3 has terminal selected-lane proof; full required CI and normal review/read/queue gates remain. Own delta is174 additions+3 deletions in one test file; dependency source and its gates remain separate. Normal current-head CI/review/any applicable read and merge-queue gates remain.

GitHub subsequently reported a real CONFLICTING main state at unchanged ee707b3. No new Ready run had appeared; the old draft gate remained insufficient. Per the coordinator, composed exact owner main-conflict resolution a10436f from #1328 into a6d06f3. The four production files are byte-identical to both owner a10436f and prior0be27961. The isolated test file is byte-identical to the qualified ee707b3; the entire new tree differs from owner a10436f only in that test file. This is a normal real-conflict merge, not a CI restart or empty change. Fresh lane44255718969 completed SUCCESS on a6d06f3: both architectures ran1,619 tests, all1,619 passed, zero skips; both new runtime controls plus native completion/reclaim explicitly passed. Required44255727597 completed SUCCESS on this exact head: the mandatory-bwrap inventory verified4,974 workspace tests passed exactly once and zero runtime skips. Current code receipt6971662473 and explicit no-security-issues receipt6971690989 are clear; there are zero review threads. The normal queue merged this PR at5e5c67310d36ca1f5ea9c0f8d4dd133ba6075c0c on2026-11-18 07:27:32 UTC. The isolated fixture is byte-identical to tested a6d06f3. Stable patch IDs match both its own fixture b9a4814f623206e2f31ea36c9dadb7e5ca5f821a and Lead's four-file runtime patch bd9302b6493dc4f22bbd82331fc4383149b02953 between reviewed source and landing. No activation.

@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 18, 2026 06:51
@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T07:06:41.647606Z a6d06f3 Manual request
🔒 Security Review ✅ Completed 2026-11-18T07:08:15.517516Z a6d06f3 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: a6d06f35ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: a6d06f35ec

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 5e5c673 Nov 18, 2026
32 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1199-native-activity-controls branch November 18, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant