Skip to content

Persist typed dependency waits in the protected item lease row - #1327

Merged
oxa-orchestrator[bot] merged 7 commits into
mainfrom
agent/1199-dependency-waits
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 7 commits into
mainfrom
agent/1199-dependency-waits

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

T3 · CORE. Feature A, #1199 typed blockers/deadlines and #307 row night-watch + feeder + goal-loop: board assignment/leases. First bounded dependency foundation; atomic yield/resume and bounded wakes follow separately. Lead owns actual dependency/quiescence/runtime evidence; Work2 owns isolated real-CLI controls.

Persist optional DependencyWait in the SAME protected AssignmentData row. Identity is a required-CI run, reviewed PR/head, another work item or owner-read request, with a future deadline. Claims::wait_for_dependency reuses the factored complete binding/latest host-renewed-receipt guard and checks exact row revision under the existing lock. Trusted verification must establish the dependency and safe quiescence; heartbeat, worker output and timeout are not evidence.

Waits survive reopening, retry idempotently and suppress action-stalled only until their wake deadline, after all original positive/bounded/overflow clock checks. A deadline cannot clear/release/reassign or advance action. Original Lease/NativeBinding/attempts remain; new admission clears old wait. Old JSON defaults/omits the optional field. Worker exclusion stays conservative until the separate atomic resume/yield slice. Full blocked-not-stopped/runtime acceptance remains unproven.

Tests cover reopened waits/deadlines, heartbeat not extending the deadline, absent-field decoding, invalid/unknown evidence and stale revision, full host/renewal/generation fences, actual new-admission cleanup and overflow refusal while waiting. All original activity controls remain. No second store, caller/task/checkout takeover or helper/runtime activation.

Current 67ee4bb, 275 additions+22 deletions=297 total lines, eight Rust files. The latest normal main merge resolves a verified board.rs conflict, preserving main's check_recovery module and our Dependency exports. ALL SEVEN other owned blobs/tests match approved781. Zero-context own patch-id remains44fb452e0db2e5a4cfb33f53301bb21c26f2ce32; the existing Owner06:48Z source-read decision is resolved. No repeat source-read or size waiver requested.

Before44250289773 at tests-first9b reproduced the wait early-return overflow defect: ARM1614run/1613pass/one new runtime assertion failed; x86job also failed. Corrected781 selected44251467773 passed1614/1614 on EACHx86/ARM,0skip+doctests. It could not start PR checks while GitHub reported the real conflict. That old result is not current-head qualification.

Current exact67ee lane44255872057 and required44255880532 are running, one120s observer each. Fresh connected Code/security remain gates. Localformat/diffchecks only; no local builds/tests. Wait contract; separate resume/wake contract.

@oxa-agent

oxa-agent Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Draft tests-first acceptance control at9b47bbcad01e848c919e2f60ec018cd62ce3f37a: the wait-specific early return currently masks the existing silence/time overflow refusals. The new assertions use the existing public Assignment::stalled API and are expected to fail at runtime. This draft is not a merge candidate; I will consume that CI result, then move the wait decision after the original clock validation. The landed #1311 source is unaffected. No old source approval or selected result is qualification for this new boundary.

@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 18, 2026 06:53
@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T07:06:52.442487Z 67ee4bb Manual request
🔒 Security Review ✅ Completed 2026-11-18T07:08:23.805527Z 67ee4bb Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 67ee4bbd1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 67ee4bbd1e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 4de8d00 Nov 18, 2026
31 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1199-dependency-waits branch November 18, 2026 07:22
@oxa-agent

oxa-agent Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

#1327 is MERGED at 4de8d00916ffe5191298a53d34e8029d1d0938e0 (2026-11-18 07:22:56 UTC). Queue run44257154429 succeeded on that exact integrated tree. All eight owned files are byte-identical to approved source67ee4bbd.

Qualification: selected44255872057 succeeded with1,620 tests on each x86/ARM, zero skips; Ready required44255880532 succeeded; current Code6971665883 and Security6971693677 are clean with no review threads. Owner06:48 source-read and its documented pure-main carry are resolved.

Available from oxa_work::board: Dependency::{RequiredCi(u64), ReviewedHead { number, head }, WorkItem(u64), OwnerRead(String)}, DependencyWait { dependency, deadline }, and Claims::wait_for_dependency(worker, host, &NativeBinding, &ItemLease, now, expected_revision, &DependencyWait, verify) -> Result. The verifier establishes exact dependency and safe quiescence under the existing Claims lock; it must not take task/repository locks or call Claims. Parking retains the original item, lease, binding, attempt and accounting. This foundation alone does not qualify runtime yield/resume.

The prepared separate322-line resume/wake slice follows on a main-based PR. Lead owns runtime signal/wake integration; Work2 owns real CLI conformance. No activation or new authority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant