Repository navigation
Persist typed dependency waits in the protected item lease row - #1327
Conversation
|
Draft tests-first acceptance control at9b47bbcad01e848c919e2f60ec018cd62ce3f37a: the wait-specific early return currently masks the existing silence/time overflow refusals. The new assertions use the existing public Assignment::stalled API and are expected to fail at runtime. This draft is not a merge candidate; I will consume that CI result, then move the wait decision after the original clock validation. The landed #1311 source is unaffected. No old source approval or selected result is qualification for this new boundary. |
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
#1327 is MERGED at Qualification: selected44255872057 succeeded with1,620 tests on each x86/ARM, zero skips; Ready required44255880532 succeeded; current Code6971665883 and Security6971693677 are clean with no review threads. Owner06:48 source-read and its documented pure-main carry are resolved. Available from oxa_work::board: Dependency::{RequiredCi(u64), ReviewedHead { number, head }, WorkItem(u64), OwnerRead(String)}, DependencyWait { dependency, deadline }, and Claims::wait_for_dependency(worker, host, &NativeBinding, &ItemLease, now, expected_revision, &DependencyWait, verify) -> Result. The verifier establishes exact dependency and safe quiescence under the existing Claims lock; it must not take task/repository locks or call Claims. Parking retains the original item, lease, binding, attempt and accounting. This foundation alone does not qualify runtime yield/resume. The prepared separate322-line resume/wake slice follows on a main-based PR. Lead owns runtime signal/wake integration; Work2 owns real CLI conformance. No activation or new authority. |
T3 · CORE. Feature A, #1199 typed blockers/deadlines and #307 row night-watch + feeder + goal-loop: board assignment/leases. First bounded dependency foundation; atomic yield/resume and bounded wakes follow separately. Lead owns actual dependency/quiescence/runtime evidence; Work2 owns isolated real-CLI controls.
Persist optional DependencyWait in the SAME protected AssignmentData row. Identity is a required-CI run, reviewed PR/head, another work item or owner-read request, with a future deadline. Claims::wait_for_dependency reuses the factored complete binding/latest host-renewed-receipt guard and checks exact row revision under the existing lock. Trusted verification must establish the dependency and safe quiescence; heartbeat, worker output and timeout are not evidence.
Waits survive reopening, retry idempotently and suppress action-stalled only until their wake deadline, after all original positive/bounded/overflow clock checks. A deadline cannot clear/release/reassign or advance action. Original Lease/NativeBinding/attempts remain; new admission clears old wait. Old JSON defaults/omits the optional field. Worker exclusion stays conservative until the separate atomic resume/yield slice. Full blocked-not-stopped/runtime acceptance remains unproven.
Tests cover reopened waits/deadlines, heartbeat not extending the deadline, absent-field decoding, invalid/unknown evidence and stale revision, full host/renewal/generation fences, actual new-admission cleanup and overflow refusal while waiting. All original activity controls remain. No second store, caller/task/checkout takeover or helper/runtime activation.
Current 67ee4bb, 275 additions+22 deletions=297 total lines, eight Rust files. The latest normal main merge resolves a verified board.rs conflict, preserving main's check_recovery module and our Dependency exports. ALL SEVEN other owned blobs/tests match approved781. Zero-context own patch-id remains44fb452e0db2e5a4cfb33f53301bb21c26f2ce32; the existing Owner06:48Z source-read decision is resolved. No repeat source-read or size waiver requested.
Before44250289773 at tests-first9b reproduced the wait early-return overflow defect: ARM1614run/1613pass/one new runtime assertion failed; x86job also failed. Corrected781 selected44251467773 passed1614/1614 on EACHx86/ARM,0skip+doctests. It could not start PR checks while GitHub reported the real conflict. That old result is not current-head qualification.
Current exact67ee lane44255872057 and required44255880532 are running, one120s observer each. Fresh connected Code/security remain gates. Localformat/diffchecks only; no local builds/tests. Wait contract; separate resume/wake contract.