Repository navigation
Core #1199: resume verified dependency waits and bound activity wakes - #1341
Conversation
Resolve actual board export and dependencies conflicts; preserve resume controls and main recovery export.
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
#1341 is MERGED at Current-source qualification: selected44258806537 succeeded with1,626 passing tests on each x86/ARM, zero skips and doctests; Ready required44259025622 succeeded with4,981 expected workspace tests executed once, zero runtime skips. Owner07:27 exact-source read resolved; Code6972158105 and Security6972182330 explicitly reviewed37ff and are clean; no unresolved review threads. Original CI observers completed successfully. Available in oxa_work::board: Claims::resume_dependency_for(worker,host,&NativeBinding,&ItemLease,now,expected_revision,&DependencyWait,verifyFreshClear)->Result; ActivityTiming { heartbeat_interval_secs, silence_secs }, validate and next_wake. Same Claims lock/row, original full receipt/renewed expiry/binding, exact wait and revision; fresh clearance plus no other unparked worker work. Imported holds and expired unfinished work remain fences. No deadline-based clearance, attempt refund, lease replacement or additional store. Lead owns both native_queue runnable selection and Consumer::once hosted preflight. Work2 retains producer/isolated CLI and has handed the exact shared hunk to Lead. Runtime productive-next/all-parked acceptance remains separate and unqualified by this Core landing. No activation. |
Implements the next Core data/rules slice of #1199 and the #307 native Board/feeder row: a worker parked on a verified dependency can take its next eligible item, then resume the original attempt only after fresh clearance and an atomic worker-idle check.
T3. Reuses the existing Claims row, private atomic writer and directory lock.
resume_dependency_forchecks the original full host-bound lease, latest renewable expiry, immutable NativeBinding, exact stored dependency and current assignment revision. Other unfinished running work, including expired leases, and imported holds block resume. Deadlines never release work, refund attempts or grant clearance. Optional owner-selected ActivityTiming validates intervals and computes bounded future wakes without an overdue spin loop. Lead owns runtime signal/wake/recovery fences; Work2 owns real CLI conformance.Own delta:322 lines (314 additions +8 deletions), six Rust files. Actual conflicts with landed #1327 were resolved by normal main merge; main's check_recovery export and all resume tests are preserved. The own patch ID is unchanged. No configuration activation, additional store or authority.
Validation for current head
37ff9e2387fd629dc936d546d5cea62c21c3c381:Behavior controls exercise actual next-item admission while parked, original receipt/binding/attempt preservation, busy/false/stale/wrong-wait refusal, simultaneous clears allowing only one running item, import holds, bounded wake and arithmetic overflow. Previous composition22fd selected CI44255276174 passed1,618 tests per x86/ARM with zero skips; that is historical evidence, not current-head qualification. Normal current CI, clean connected reviews and integrated merge queue remain required.