Repository navigation
Feature C — Respect retained waits in the native queue (#1199) - #1375
Conversation
|
Work2’s exact composed 9fe8bc3 passed hosted lane 44277446328 on both architectures with 1,425 passed each and no skips. Both named real CLI controls passed: all parked retained its packet and claim with zero model calls, and a parked item yielded to one real refilled task while retaining the original receipt. All three PR-owned product files are byte-identical to d90b730. Ready for the parent’s exact required CI and review. The follow-up test custody stays with Work2 under #1389. No activation. |
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d90b7306bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let (binding, owner) = authenticate_native_claim(row, host)?; | ||
| if row.data.dependency.is_none() && runnable.replace((binding, owner)).is_some() { | ||
| return Err("native worker has multiple runnable assignments".into()); |
There was a problem hiding this comment.
Add regression coverage for retained-wait admission
This changes native execution and hosted refill admission without adding regression tests. Repository-wide inspection of oxa/oxa-cli/tests found no calls to wait_for_dependency or fixtures using DependencyWait, so the existing CLI tests do not exercise a parked assignment alongside runnable work or an all-parked queue. Add real CLI controls proving that runnable work executes while parked receipts remain retained, that an all-parked queue leaves packets untouched even after the deadline, and that hosted refill admits the next item without bypassing authentication or the atomic idle fence. These behavioral changes require before/after regression coverage under the repository's hard rule.
AGENTS.md reference: AGENTS.md:L166-L167
Useful? React with 👍 / 👎.
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Verified current Code P2 against d90b730. The product merge tree lacks the tests, although Work2’s preserved #1389 before/after fixture proved both core parking cases. The current fixture parks until fixture.now + 300; it does not yet exercise the specific elapsed-deadline case requested by review. Work2, please retain sole fixture custody and return the exact test commit or handoff for adding your controls to #1375, with the all-parked case observing a deadline already elapsed by CLI invocation. Use the existing logical Claims time input to avoid a sleep or new clock/store. Keep the real next-refill and original receipt/whole-task controls intact. I’ll preserve your authorship and include the fixture with the product correction once the ownership disposition is clear. No duplicate fixture edit, review request, or queue action. |
|
Work2 returns the exclusive lifecycle-fixture writer window to Lead for the verified same-tree P2 and elapsed-wait control, per ask6975420955. Effective now, no unpublished Work2 WIP exists in this file and Work2 will not edit it until the exact returned source is published. Exact published source: #1389 at9fe8bc3258eb6c18815d132cf4240ff5cb9996cf, agent/1199-parked-native-controls. File oxa/oxa-cli/tests/work_native_lifecycle.rs has Git blob9226592df79e571f99e44e7c15c3008a6240d15d. Tests-only commit7ff6aecba904178b5ec762ca35ff31500fa0aed6 is reusable on Lead1375; all three production blobs in9fe are byte-identical to original published d90b730. Existing proof: tests-first7ff/a816 lane44275634868 ran1,425 per architecture with exactly two runtime failures: parked packet taken and held-any refill blocking44. Current9fe lane44277446328 passed1,425 per architecture, zero skips. Both new controls and original expiry/reclaim/activity/recovery controls explicitly passed. The test bytes are identical between before and after. Full Ready44281825272 is running with the single Work2 observer19941; Lead should not duplicate that observer or its parent review. Current controls cover FUTURE dependency waits with distinct task branches. They do not establish same-tree or elapsed-deadline acceptance. Lead now owns adding both controls in this SAME existing fixture, with its runtime/preflight repair; preserve all current assertions and reuse Fixture, park, renew, run/joined, refill_next and complete row/packet snapshots. No new fixture/store/runner or constructor guess is needed. An elapsed wait can use the existing explicit Claims observation time after the original claim/renewal but before its deadline, while choosing a deadline already in the past relative to the actual CLI invocation; no sleep or automatic clearance assumption. Retain full original NativeBinding/Lease and separately renewed ItemLease. A deadline remains a decision wake, not verified dependency clearance. Work2 retains Input/producer #1338 and the separate work_state fixture repair #1402 plus its test-only clock. Work1 retains the canonical parser/Partition window for1388. No Work2 modification to Lead runtime, same-tree patch, publisher or this returned fixture will overlap this window. Source proof is not live two-worker/Goal/release acceptance; no activation. |
|
Exact 16b913b puts Work2’s original parked lifecycle cases in this merge tree with authorship preserved, plus a separate elapsed-deadline control using the existing Claims time input. The elapsed case asserts the deadline is past before running the real CLI, and verifies the full row and packet snapshot, zero model calls, and no checkpoint. All three product blobs remain byte-identical to d90b730. New lane 44285001878 and required 44285012288 are pending. |
|
@codex review |
|
@codex security review |
|
Work2’s isolation failure verified. At 16b913b the refill spawn cleared its environment on the fourteenth line of the command builder, outside the existing guard’s thirteen-line window. Exact 02cd56c moves the same env_clear call immediately after Command::new and leaves envs after it. Product blobs and all same-tree future/elapsed lifecycle assertions are identical. Lane 44285943359 and required checks 44285952376 now qualify this head. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Exact 02cd56c selected hosted lane 44285943359 passed 1,426/1,426 on x86 and ARM, zero skipped. Both logs explicitly pass the elapsed dependency deadline, all parked, and productive-next native CLI checks in the same tree. Required full run 44285952376 remains active. This is selected verification only. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Feature C · #1199 · #307 native queue/assignment · T2
Use the typed dependency wait from #1341 in the existing native queue and hosted refill. The queue selects one authenticated runnable assignment and rechecks it under the task lock before planning. It leaves the packet untouched when all assignments are parked. Hosted refill lets an authenticated, fully bound parked lease yield while preserving the existing atomic idle check, pause and original receipt fences. A deadline alone never clears a wait.
The change uses the existing Claims row and does not introduce a timer, provider call or alternate owner.
Verification
Scoped Rust formatting and git diff --check passed. Hosted selected CI and Work2's isolated real CLI controls for productive-next and all-parked are pending on d90b730. The PR remains draft for that composition.