Repository navigation
work: qualify parked native refill through the real CLI - #1389
oxa-agent[bot] wants to merge 3 commits into
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Pull request was closed
Incorporated by #1375, actually merged at cada2aa. Closing this superseded controls PR; the branch and proof remain preserved.
The landed lifecycle fixture blob 5ce295fca94db49a5cb8c05a287227b4e4a39162 exactly matches Lead02cd56cd. Relative to this PR9fe, it retains all original assertions, moves env_clear before the long argument list for the existing isolation guard, parameterizes the parked observation/deadline and adds the elapsed-wait case. Productive-next and all-parked controls are incorporated. No fixture or product changes remain to land from this PR. Same-tree runtime proof and broader live Goal acceptance remain Lead-owned.
T3 runtime composition; the owned T1 CLI fixture is166 changed lines. #1199 / #1341 and #307 board assignment/leases.
A retained dependency wait was treated as runnable by native dispatch, while refill treated every worker lease as busy. This composes Lead1375 actual d90b730 with two isolated real CLI controls. All three production files are byte-identical to that published owner source; no runtime implementation is duplicated or rewritten.
The actual CLI skips authenticated fully bound waits, selects one runnable assignment, and rechecks that exact selection under the existing task lock. Hosted refill allows a verified parked lease to yield while preserving atomic hosted idle/bootstrap, missing-row, target lease, late pause and original receipt fences. Legacy no-host still treats held leases as busy.
The lifecycle controls prove all parked work remains idle without taking its packet, changing its full Claims row or calling a model. A parked42 lease must permit the real protected refill to publish44; real native execution must then finish and settle only44 original receipt, retain42 full row and packet byte-for-byte, and replay with no second model call. Existing expiry/reclaim/activity controls remain. The only test-helper change shares its existing90-second bounded child join.
Tests-first7ff6aecba904178b5ec762ca35ff31500fa0aed6 on actual pre-fix a816fc4 failed exactly these two runtime assertions in lane44275634868 on x86_64 and ARM64:1,425 ran,1,423 passed, two failed, zero skips. Both failed-job tails were inspected: the parked packet was taken at478 and the real refill produced no44 binding at504. These are runtime regressions, not compile failures. Test bytes are unchanged in current9fe8bc3258eb6c18815d132cf4240ff5cb9996cf. Current selected44277446328 completed SUCCESS:1,425 tests per x86_64/ARM64 architecture, all passed, zero skips. Both new controls and all four original lifecycle controls explicitly passed on both architectures. Selected crates: oxa-cli and oxa-parity. Scoped rustfmt/diff checks pass. Full Ready44281825272 failed only the unchanged environment-isolation guard at work_native_lifecycle.rs251: the existing env_clear is beyond its13-line source window after the long argument list. Lead now owns the returned exclusive fixture window (1375#6975609805); the same-semantics builder ordering fix is routed there alongside same-tree and elapsed-wait controls. The guard/allowlist will not change. Fresh current-head full CI and normal reviews/read/queue remain gates. No local tests/compilation.
This issue-based fixture qualifies parked scheduling only. Reviewed FIX execution1267, live producer1338, canonical Session/Goal provenance, actual provider/network-vs-publication enforcement, operator imports/partition and1264 hold remain independent live gates. Lead owns provisioning/running its two native workers. Work2 started no real task, claim or helper. Normal current reviews/read/queue apply; no duplicate parent observer or review request.