Repository navigation
feat: map the Wireless response members from the 1.74.0 gap report - #420
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This was referenced Sep 9, 2026
Merged
danielabbatt
force-pushed
the
feat/map-appliance-members
branch
from
September 29, 2026 12:15
602c48c to
92147f4
Compare
danielabbatt
force-pushed
the
feat/map-wireless-members
branch
from
September 29, 2026 12:15
a441782 to
8cbf363
Compare
danielabbatt
force-pushed
the
feat/map-appliance-members
branch
from
September 29, 2026 12:43
92147f4 to
fb6cbf1
Compare
danielabbatt
force-pushed
the
feat/map-wireless-members
branch
from
September 29, 2026 12:43
8cbf363 to
da38eeb
Compare
danielabbatt
force-pushed
the
feat/map-appliance-members
branch
from
September 29, 2026 12:52
fb6cbf1 to
11280e7
Compare
danielabbatt
force-pushed
the
feat/map-wireless-members
branch
from
September 29, 2026 12:52
da38eeb to
f9d0532
Compare
Nineteen members the v1.74.0 spec documents that the models lacked, the fourth per-area batch: Ssid.CampusGateway and .WlanIdentifier; ElectronicShelfLabelSettingsNetwork.Sepioo; AirMarshal.Encryption, .Manufacturers and .Types; Gre.ClientIsolation; NaiRealm.Name; FailedConnection.Radio; DevicesWirelessZigbeeEnrollmentsDetailed .EnrollmentStartedAt; ConnectivityEvents.SsidNumber; SsidsStatusesByDeviceItemBasicServiceSetRadio.Index; and the API's current channel-utilization names on Wifi alongside the legacy ones, which are kept because it is not known which set the API sends today. Three members that could never bind are corrected: OrganizationWirelessControllerDevicesInterfacesL2UsageHistoryByIntervalGetResponse .Meta was mapped to "name" instead of "meta". WirelessRfProfileCreateUpdateRequest.Be was mapped to "be" where the API sends "dot11be"; it is now Dot11be, and WirelessRfProfileBe gains Mode and the per-SSID-group Ssids the spec documents. DevicesWirelessZigbeeEnrollmentsDetailed had a property called EnrollmentStartedAt bound to "enrollmentStatus"; it is renamed EnrollmentStatus and the new EnrollmentStartedAt is the real timestamp. WirelessMemberTests covers the new members and the corrections.
danielabbatt
force-pushed
the
feat/map-appliance-members
branch
from
September 29, 2026 12:56
11280e7 to
84f83fe
Compare
danielabbatt
force-pushed
the
feat/map-wireless-members
branch
from
September 29, 2026 12:56
f9d0532 to
8ca10fa
Compare
danielabbatt
changed the base branch from
feat/map-appliance-members
to
main
September 29, 2026 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #419, in the chain that starts at #415
Base is
feat/map-appliance-members. Merge the chain in order with merge commits, then retarget this tomain. Changelog label1.74.10assumes that.What
Fourth per-area batch from
gap-report-v1.74.0.md: 19 Wireless members the spec documents that the models lacked, across 12 classes.Ssid.CampusGateway,.WlanIdentifierSsidCampusGatewaycontainingSsidCampusGatewayCluster {id}ElectronicShelfLabelSettingsNetwork.SepiooElectronicShelfLabelSettingsNetworkSepioo {hostname}AirMarshal.Encryption,.Manufacturers,.Typesstring?(spec enum WEP/WPA/open, kept as string), twoList<string>?Gre.ClientIsolation,NaiRealm.Name,FailedConnection.Radio,ConnectivityEvents.SsidNumber,SsidsStatusesByDeviceItemBasicServiceSetRadio.Index,DevicesWirelessZigbeeEnrollmentsDetailed.EnrollmentStartedAtWifi(channel utilization)startTime/endTime/utilizationTotal/utilization80211/utilizationNon80211alongside the legacystart_ts/end_ts/utilization/wifi/non_wifi. I don't know which set the live API sends, so nothing was removedThree corrections (never bound before)
OrganizationWirelessControllerDevicesInterfacesL2UsageHistoryByIntervalGetResponse.Metawas[DataMember(Name = "name")]. Its two sibling L2 responses say"meta"; this one now does too.WirelessRfProfileCreateUpdateRequest.Bewas mapped tobe; the API sendsdot11be. RenamedDot11be, andWirelessRfProfileBegains the spec'sModeandSsids(per-SSID-group{enabled}, keyed"1"to"4", as aDictionary). Breaking rename, but the old property never bound.DevicesWirelessZigbeeEnrollmentsDetailed.EnrollmentStartedAtwas astring?bound toenrollmentStatus, found because adding the realenrollmentStartedAtcollided with it. RenamedEnrollmentStatus; the newEnrollmentStartedAtis aDateTime?.Verification
All 13 edited files kept their BOM state and line endings.